From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6821C48BCF for ; Wed, 9 Jun 2021 11:25:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31E5A61108 for ; Wed, 9 Jun 2021 11:25:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31E5A61108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqwLK-0005Tl-Bc for qemu-devel@archiver.kernel.org; Wed, 09 Jun 2021 07:25:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqwJn-0003Ze-76 for qemu-devel@nongnu.org; Wed, 09 Jun 2021 07:24:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqwJj-0006z4-BU for qemu-devel@nongnu.org; Wed, 09 Jun 2021 07:24:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623237853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OGb8DW1FlrzX4AXczRI967C536ZO/hECIGtO7xZWU9U=; b=TeXhHObMTaDVID69TIN+m+Gc6kqUMGY2i6eb83DoVMsFTBxKUF4QrXUV3twJBaMP61xv9L G76tCvEOaGaVHZdoXhKVgN8OuqFm+e7Xh8bjOZnbzkSGBN0wqqEIGE30gsrHMJOGVZua+p WJhc+Cb/yAZrT/znvb2cqv0q83QVQFQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-m9KBOdjONvO687WLCmi04A-1; Wed, 09 Jun 2021 07:24:12 -0400 X-MC-Unique: m9KBOdjONvO687WLCmi04A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8EF699127F for ; Wed, 9 Jun 2021 11:24:11 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-69.ams2.redhat.com [10.36.113.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30A26608BA; Wed, 9 Jun 2021 11:24:08 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 563A918003B6; Wed, 9 Jun 2021 13:24:05 +0200 (CEST) Date: Wed, 9 Jun 2021 13:24:05 +0200 From: Gerd Hoffmann To: Thomas Huth Subject: Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional Message-ID: <20210609112405.pyv62l22g5ympoe4@sirius.home.kraxel.org> References: <20210609100240.1285032-1-thuth@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210609100240.1285032-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libvir-list@redhat.com, smitterl@redhat.com, Eric Blake , qemu-devel@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jun 09, 2021 at 12:02:40PM +0200, Thomas Huth wrote: > Libvirt's "domcapabilities" command has a way to state whether > certain graphic frontends are available in QEMU or not. Originally, > libvirt looked at the "--help" output of the QEMU binary to determine > whether SDL was available or not (by looking for the "-sdl" parameter > in the help text), but since libvirt stopped doing this analysis of > the help text, the detection of SDL is currently broken, see: > > https://bugzilla.redhat.com/show_bug.cgi?id=1790902 > > QEMU should provide a way via the QMP interface instead. The simplest > way, without introducing additional commands, is to make the DisplayType > enum entries conditional, so that the enum only contains the entries if > the corresponding CONFIG_xxx switches have been set. Hmm, that'll break for the "dnf remove qemu-ui-sdl" case ... take care, Gerd