From: Stefano Garzarella <sgarzare@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mst@redhat.com
Subject: Re: [PATCH 1/7] vhost: Add Error parameter to vhost_dev_init()
Date: Thu, 10 Jun 2021 11:05:16 +0200 [thread overview]
Message-ID: <20210610090516.jca55r3evopt3tth@steredhat> (raw)
In-Reply-To: <20210609154658.350308-2-kwolf@redhat.com>
On Wed, Jun 09, 2021 at 05:46:52PM +0200, Kevin Wolf wrote:
>This allows callers to return better error messages instead of making
>one up while the real error ends up on stderr. Most callers can
>immediately make use of this because they already have an Error
>parameter themselves. The others just keep printing the error with
>error_report_err().
>
>Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>---
> include/hw/virtio/vhost.h | 2 +-
> backends/cryptodev-vhost.c | 5 ++++-
> backends/vhost-user.c | 4 ++--
> hw/block/vhost-user-blk.c | 4 ++--
> hw/net/vhost_net.c | 6 +++++-
> hw/scsi/vhost-scsi.c | 4 +---
> hw/scsi/vhost-user-scsi.c | 4 +---
> hw/virtio/vhost-user-fs.c | 3 +--
> hw/virtio/vhost-user-vsock.c | 3 +--
> hw/virtio/vhost-vsock.c | 3 +--
> hw/virtio/vhost.c | 16 ++++++++++------
> 11 files changed, 29 insertions(+), 25 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
next prev parent reply other threads:[~2021-06-10 9:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 15:46 [PATCH 0/7] vhost-user-blk: Implement reconnection during realize Kevin Wolf
2021-06-09 15:46 ` [PATCH 1/7] vhost: Add Error parameter to vhost_dev_init() Kevin Wolf
2021-06-10 9:05 ` Stefano Garzarella [this message]
2021-06-11 19:14 ` Raphael Norwitz
2021-06-09 15:46 ` [PATCH 2/7] vhost: Distinguish errors in vhost_backend_init() Kevin Wolf
2021-06-10 9:07 ` Stefano Garzarella
2021-06-11 19:43 ` Raphael Norwitz
2021-06-09 15:46 ` [PATCH 3/7] vhost: Return 0/-errno in vhost_dev_init() Kevin Wolf
2021-06-10 9:09 ` Stefano Garzarella
2021-06-11 19:49 ` Raphael Norwitz
2021-06-09 15:46 ` [PATCH 4/7] vhost-user-blk: Add Error parameter to vhost_user_blk_start() Kevin Wolf
2021-06-10 9:11 ` Stefano Garzarella
2021-06-11 19:55 ` Raphael Norwitz
2021-06-09 15:46 ` [PATCH 5/7] vhost: Distinguish errors in vhost_dev_get_config() Kevin Wolf
2021-06-10 9:16 ` Stefano Garzarella
2021-06-11 20:08 ` Raphael Norwitz
2021-06-09 15:46 ` [PATCH 6/7] vhost-user-blk: Factor out vhost_user_blk_realize_connect() Kevin Wolf
2021-06-10 9:18 ` Stefano Garzarella
2021-06-11 20:11 ` Raphael Norwitz
2021-06-09 15:46 ` [PATCH 7/7] vhost-user-blk: Implement reconnection during realize Kevin Wolf
2021-06-10 9:23 ` Stefano Garzarella
2021-06-11 20:15 ` Raphael Norwitz
2021-06-30 12:39 ` [PATCH 0/7] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610090516.jca55r3evopt3tth@steredhat \
--to=sgarzare@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).