From: Eric Blake <eblake@redhat.com>
To: sweeaun <swee.aun.khor@intel.com>
Cc: khairul.anuar.romli@intel.com, qemu-devel@nongnu.org,
vivek.kasireddy@intel.com
Subject: Re: [PATCH] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option
Date: Mon, 14 Jun 2021 09:11:29 -0500 [thread overview]
Message-ID: <20210614141129.plffhclmdczft3g6@redhat.com> (raw)
In-Reply-To: <20210614080542.5905-1-swee.aun.khor@intel.com>
On Mon, Jun 14, 2021 at 04:05:42PM +0800, sweeaun wrote:
> -display gtk,monitor-num=<value>
>
> Signed-off-by: sweeaun <swee.aun.khor@intel.com>
> ---
> qapi/ui.json | 3 ++-
> qemu-options.hx | 2 +-
> ui/gtk.c | 15 +++++++++++++++
> 3 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index 1052ca9c38..c3363c7ad5 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -1041,7 +1041,8 @@
> ##
> { 'struct' : 'DisplayGTK',
> 'data' : { '*grab-on-hover' : 'bool',
> - '*zoom-to-fit' : 'bool' } }
> + '*zoom-to-fit' : 'bool',
> + '*monitor-num' : 'int' } }
Missing documentation of the new member. Also, get rid of the tab damage.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-06-14 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 8:05 [PATCH] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option sweeaun
2021-06-14 14:11 ` Eric Blake [this message]
2021-06-14 15:00 ` Markus Armbruster
2021-06-16 1:28 ` Khor, Swee Aun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614141129.plffhclmdczft3g6@redhat.com \
--to=eblake@redhat.com \
--cc=khairul.anuar.romli@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=swee.aun.khor@intel.com \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).