From: Eric Blake <eblake@redhat.com>
To: Zhiwei Jiang <elish.jiang@ucloud.cn>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: Re: [PATCH] block: fix build waring
Date: Mon, 14 Jun 2021 13:39:52 -0500 [thread overview]
Message-ID: <20210614183952.do2vhrnsrricakmj@redhat.com> (raw)
In-Reply-To: <20210613093821.774562-1-elish.jiang@ucloud.cn>
On Sun, Jun 13, 2021 at 05:38:21PM +0800, Zhiwei Jiang wrote:
In the subject, s/waring/warning/
> when i compile this file with some error message
> ../block.c: In function ‘bdrv_replace_node_common’:
> ../block.c:4903:9: error: ‘to_cow_parent’ may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> bdrv_remove_filter_or_cow_child(to_cow_parent, tran);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Signed-off-by: Zhiwei Jiang <elish.jiang@ucloud.cn>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This looks identical to
https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg01229.html
which has a more complete commit message and is already on Kevin's
tree for an upcoming pull request.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2021-06-14 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 9:38 [PATCH] block: fix build waring Zhiwei Jiang
2021-06-13 15:03 ` Peter Maydell
2021-06-14 18:39 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614183952.do2vhrnsrricakmj@redhat.com \
--to=eblake@redhat.com \
--cc=elish.jiang@ucloud.cn \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).