From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF49C48BE5 for ; Tue, 15 Jun 2021 05:32:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06E5D613F5 for ; Tue, 15 Jun 2021 05:32:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06E5D613F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lt1gx-0006o5-Nt for qemu-devel@archiver.kernel.org; Tue, 15 Jun 2021 01:32:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lt1gD-00067I-Ar for qemu-devel@nongnu.org; Tue, 15 Jun 2021 01:32:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51348) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lt1g8-0007V7-CU for qemu-devel@nongnu.org; Tue, 15 Jun 2021 01:32:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623735119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TSibzthVDv4zGuqqdzLaNVw7QnUeADeIJ1XnA9toPrk=; b=IygzXnR2FPJqpyCONIeOXSD+zJG1KRoat0xODox1O3WWqV996fEo9kGhRCWWITMgNO74ep rm/Jng0DrTfglP7PbIb3UYplWsgOKgW8XK0PIOb0SX38gUf2+uJ9fJPaHTog/DIpqUAfbg RGr3K2t/o073vPndSAl3wgqTHUGiPaQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-g1_a1dJzMtiFHY8OhQElNg-1; Tue, 15 Jun 2021 01:31:54 -0400 X-MC-Unique: g1_a1dJzMtiFHY8OhQElNg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C39E5107ACF6; Tue, 15 Jun 2021 05:31:53 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-38.ams2.redhat.com [10.36.112.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 729735D9CA; Tue, 15 Jun 2021 05:31:53 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id B7B4B18000B2; Tue, 15 Jun 2021 07:31:51 +0200 (CEST) Date: Tue, 15 Jun 2021 07:31:51 +0200 From: Gerd Hoffmann To: Vivek Kasireddy Subject: Re: [PATCH v2 2/8] ui/egl: Add egl helpers to help with synchronization Message-ID: <20210615053151.ucxtisr5ujlsnv2g@sirius.home.kraxel.org> References: <20210610224837.670192-1-vivek.kasireddy@intel.com> <20210610224837.670192-3-vivek.kasireddy@intel.com> MIME-Version: 1.0 In-Reply-To: <20210610224837.670192-3-vivek.kasireddy@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > +void egl_dmabuf_create_fence(QemuDmaBuf *dmabuf) > +{ > + if (dmabuf->sync) { > + dmabuf->fence_fd = eglDupNativeFenceFDANDROID(qemu_egl_display, > + dmabuf->sync); > + eglDestroySyncKHR(qemu_egl_display, dmabuf->sync); > + dmabuf->sync = NULL; > + } > +} > +void egl_dmabuf_wait_sync(QemuDmaBuf *dmabuf) > +{ Hmm, still the blocking wait. Can't you do something like "qemu_set_fd_handler(dmabuf->fence_fd, ...)" to avoid the eglClientWaitSyncKHR() completely? take care, Gerd