From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, alex.bennee@linaro.org, laurent@vivier.eu
Subject: [PATCH 02/21] linux-user/aarch64: Implement setup_sigtramp
Date: Tue, 15 Jun 2021 18:11:50 -0700 [thread overview]
Message-ID: <20210616011209.1446045-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210616011209.1446045-1-richard.henderson@linaro.org>
Create and record the rt signal trampoline.
Use it when the guest does not use SA_RESTORER.
Cc: qemu-arm@nongnu.org
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/aarch64/target_signal.h | 2 ++
linux-user/aarch64/signal.c | 28 ++++++++++++++++++----------
2 files changed, 20 insertions(+), 10 deletions(-)
diff --git a/linux-user/aarch64/target_signal.h b/linux-user/aarch64/target_signal.h
index 18013e1b23..7580d99403 100644
--- a/linux-user/aarch64/target_signal.h
+++ b/linux-user/aarch64/target_signal.h
@@ -25,4 +25,6 @@ typedef struct target_sigaltstack {
#define TARGET_SEGV_MTESERR 9 /* Synchronous ARM MTE exception */
#define TARGET_ARCH_HAS_SETUP_FRAME
+#define TARGET_ARCH_HAS_SIGTRAMP_PAGE 1
+
#endif /* AARCH64_TARGET_SIGNAL_H */
diff --git a/linux-user/aarch64/signal.c b/linux-user/aarch64/signal.c
index 662bcd1c4e..65b84eb04e 100644
--- a/linux-user/aarch64/signal.c
+++ b/linux-user/aarch64/signal.c
@@ -108,7 +108,6 @@ struct target_rt_sigframe {
struct target_rt_frame_record {
uint64_t fp;
uint64_t lr;
- uint32_t tramp[2];
};
static void target_setup_general_frame(struct target_rt_sigframe *sf,
@@ -495,15 +494,7 @@ static void target_setup_frame(int usig, struct target_sigaction *ka,
if (ka->sa_flags & TARGET_SA_RESTORER) {
return_addr = ka->sa_restorer;
} else {
- /*
- * mov x8,#__NR_rt_sigreturn; svc #0
- * Since these are instructions they need to be put as little-endian
- * regardless of target default or current CPU endianness.
- */
- __put_user_e(0xd2801168, &fr->tramp[0], le);
- __put_user_e(0xd4000001, &fr->tramp[1], le);
- return_addr = frame_addr + fr_ofs
- + offsetof(struct target_rt_frame_record, tramp);
+ return_addr = default_rt_sigreturn;
}
env->xregs[0] = usig;
env->xregs[29] = frame_addr + fr_ofs;
@@ -576,3 +567,20 @@ long do_sigreturn(CPUARMState *env)
{
return do_rt_sigreturn(env);
}
+
+void setup_sigtramp(abi_ulong sigtramp_page)
+{
+ uint32_t *tramp = lock_user(VERIFY_WRITE, sigtramp_page, 8, 0);
+ assert(tramp != NULL);
+
+ /*
+ * mov x8,#__NR_rt_sigreturn; svc #0
+ * Since these are instructions they need to be put as little-endian
+ * regardless of target default or current CPU endianness.
+ */
+ __put_user_e(0xd2801168, &tramp[0], le);
+ __put_user_e(0xd4000001, &tramp[1], le);
+
+ default_rt_sigreturn = sigtramp_page;
+ unlock_user(tramp, sigtramp_page, 8);
+}
--
2.25.1
next prev parent reply other threads:[~2021-06-16 1:16 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 1:11 [PATCH 00/21] linux-user: Move signal trampolines to new page Richard Henderson
2021-06-16 1:11 ` [PATCH 01/21] linux-user: Add infrastructure for a signal trampoline page Richard Henderson
2021-06-16 13:36 ` Max Filippov
2021-06-16 1:11 ` Richard Henderson [this message]
2021-06-16 17:00 ` [PATCH 02/21] linux-user/aarch64: Implement setup_sigtramp Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 03/21] linux-user/arm: Force v2 frames for fdpic Richard Henderson
2021-06-16 17:01 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 04/21] linux-user/arm: Implement setup_sigtramp Richard Henderson
2021-06-16 13:46 ` Alex Bennée
2021-06-16 13:49 ` Alex Bennée
2021-06-16 17:40 ` Richard Henderson
2021-06-16 1:11 ` [PATCH 05/21] linux-user/alpha: " Richard Henderson
2021-06-16 16:56 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 06/21] linux-user/cris: " Richard Henderson
2021-06-16 16:37 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 07/21] linux-user/hexagon: " Richard Henderson
2021-06-16 8:07 ` Taylor Simpson
2021-06-16 15:05 ` Richard Henderson
2021-06-16 15:50 ` Richard Henderson
2021-06-16 21:37 ` Taylor Simpson
2021-06-16 23:15 ` Richard Henderson
2021-06-16 1:11 ` [PATCH 08/21] linux-user/hppa: Document non-use of setup_sigtramp Richard Henderson
2021-06-16 10:46 ` Philippe Mathieu-Daudé
2021-06-16 21:16 ` Alex Bennée
2021-06-16 1:11 ` [PATCH 09/21] linux-user/i386: Implement setup_sigtramp Richard Henderson
2021-06-16 1:11 ` [PATCH 10/21] linux-user/m68k: " Richard Henderson
2021-06-16 16:42 ` Philippe Mathieu-Daudé
2021-06-16 1:11 ` [PATCH 11/21] linux-user/microblaze: " Richard Henderson
2021-06-16 16:43 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 12/21] linux-user/mips: " Richard Henderson
2021-06-16 16:48 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 13/21] linux-user/nios2: Document non-use of setup_sigtramp Richard Henderson
2021-06-16 1:12 ` [PATCH 14/21] linux-user/openrisc: Implement setup_sigtramp Richard Henderson
2021-06-16 16:49 ` Philippe Mathieu-Daudé
2021-06-17 0:24 ` Stafford Horne
2021-06-16 1:12 ` [PATCH 15/21] linux-user/ppc: " Richard Henderson
2021-06-16 1:12 ` [PATCH 16/21] linux-user/riscv: " Richard Henderson
2021-06-16 16:50 ` Philippe Mathieu-Daudé
2021-06-18 1:29 ` Alistair Francis
2021-06-16 1:12 ` [PATCH 17/21] linux-user/s390x: " Richard Henderson
2021-06-16 16:52 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 18/21] linux-user/sh4: " Richard Henderson
2021-06-16 16:53 ` Philippe Mathieu-Daudé
2021-06-16 1:12 ` [PATCH 19/21] linux-user/sparc: " Richard Henderson
2021-06-16 1:12 ` [PATCH 20/21] linux-user/xtensa: " Richard Henderson
2021-06-16 13:35 ` Max Filippov
2021-06-16 1:12 ` [PATCH 21/21] linux-user: Remove default for TARGET_ARCH_HAS_SIGTRAMP_PAGE Richard Henderson
2021-06-16 16:54 ` Philippe Mathieu-Daudé
2021-06-16 15:05 ` [PATCH 00/21] linux-user: Move signal trampolines to new page Alex Bennée
2021-06-16 15:09 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616011209.1446045-3-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).