From: Eric Blake <eblake@redhat.com>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 1/1] input: Add lang1 and lang2 to QKeyCode
Date: Wed, 16 Jun 2021 12:32:55 -0500 [thread overview]
Message-ID: <20210616173255.gcrwwhssdtkbfi5w@redhat.com> (raw)
In-Reply-To: <20210616144522.55643-2-akihiko.odaki@gmail.com>
On Wed, Jun 16, 2021 at 11:45:22PM +0900, Akihiko Odaki wrote:
> lang1 and lang2 represents the keys with the same names in the
> keyboard/keypad usage page (0x07) included in the "HID Usage Tables for
> Universal Serial Bus (USB)" version 1.22. Although the keys are
> described as "Hangul/English toggle key" and "Hanja conversion key" in
> the specification, the meaning depends on the variety of the keyboard,
> and it will be used as the representations of Kana and Eisu keys on
> Japanese Macs in qemu_input_map_osx_to_qcode, which is used by ui/gtk.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
> qapi/ui.json | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index ee6fde46d59..3b16b2191cc 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -786,6 +786,9 @@
> # @muhenkan: since 2.12
> # @katakanahiragana: since 2.12
> #
> +# @lang1: since 6.0.50
> +# @lang2: since 6.0.50
since 6.1
(6.0.50 is a convenience used during development, but does not point
to any released build; for that matter, it doesn't even point to a
constant commit over time the way 6.1 does).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2021-06-16 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 14:45 [PATCH 0/1] input: Add lang1 and lang2 to QKeyCode Akihiko Odaki
2021-06-16 14:45 ` [PATCH 1/1] " Akihiko Odaki
2021-06-16 17:32 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616173255.gcrwwhssdtkbfi5w@redhat.com \
--to=eblake@redhat.com \
--cc=akihiko.odaki@gmail.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).