From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>, Qiang Liu <cyruscyliu@gmail.com>,
qemu-devel@nongnu.org, Alexander Bulekov <alxndr@bu.edu>,
Bandan Das <bsd@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2] hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range
Date: Thu, 17 Jun 2021 11:55:03 +0200 [thread overview]
Message-ID: <20210617095503.nnsom4yxv7d6rl2g@sirius.home.kraxel.org> (raw)
In-Reply-To: <a7b8eb63-dae8-1086-49db-efae43660dd2@amsat.org>
On Wed, Jun 16, 2021 at 02:47:35PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/16/21 1:58 PM, Qiang Liu wrote:
> > Thx. I learned a lot about contributing to QEMU from this discussion!
>
> I think this was a misunderstanding with Gerd, the maintainer.
Indeed.
> Maintainers use some tools to ease their patch-by-email workflow.
> As a tester/reviewer you simply reply to a patch with a "Reviewed-by"
> or "Tested-by" tag (with your name and email) and the tools will
> collect your tags. Then the maintainer take the patches with the
> tags amended. So a v2 shouldn't be necessary normally.
Correct (I'm using https://pypi.org/project/b4/ btw).
I didn't follow the mail thread that closely and had the false
impression this discussion was about other tags (b4 wouldn't
create Fixes: tags for you ...).
Sorry for the confusion.
take care,
Gerd
next prev parent reply other threads:[~2021-06-17 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 10:43 [PATCH v2] hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range Philippe Mathieu-Daudé
2021-06-16 11:58 ` Qiang Liu
2021-06-16 12:47 ` Philippe Mathieu-Daudé
2021-06-17 9:55 ` Gerd Hoffmann [this message]
2021-06-17 9:56 ` Gerd Hoffmann
2021-06-22 8:54 ` Qiang Liu
2021-06-22 9:15 ` Philippe Mathieu-Daudé
2021-06-22 10:13 ` Qiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617095503.nnsom4yxv7d6rl2g@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=cyruscyliu@gmail.com \
--cc=f4bug@amsat.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).