From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626EBC2B9F4 for ; Thu, 17 Jun 2021 20:43:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC763613FE for ; Thu, 17 Jun 2021 20:43:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC763613FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltyr7-0005Rz-Cd for qemu-devel@archiver.kernel.org; Thu, 17 Jun 2021 16:43:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltyqP-0004lv-Uq for qemu-devel@nongnu.org; Thu, 17 Jun 2021 16:42:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltyqN-00025a-UN for qemu-devel@nongnu.org; Thu, 17 Jun 2021 16:42:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623962551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yd6n9QOtfu+3fv2eIocYlaLsOSw5WSqqnBztRGs5Mw4=; b=MmaRN0ibQx9tf1QjkJghNAP2/kfnd/SD1y9YpUTx2pkqkehRsml0kJLxmXKtA2IQFDYFLH s68BNr3uXNp7A2Ay3xwmYGZXKUos4Ru8SMMsKcuZByzQdPWdpHBaAvK97yh81Fn/kDD+V8 rTB+p/uR1ux8V097Syg8UOkG+pS+Rb8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-4i-U7qd2PXusyjKDtzTBQA-1; Thu, 17 Jun 2021 16:42:29 -0400 X-MC-Unique: 4i-U7qd2PXusyjKDtzTBQA-1 Received: by mail-wm1-f69.google.com with SMTP id g14-20020a05600c4eceb02901b609849650so2677912wmq.6 for ; Thu, 17 Jun 2021 13:42:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=yd6n9QOtfu+3fv2eIocYlaLsOSw5WSqqnBztRGs5Mw4=; b=hqmqO2r43KfE9lOZaDleWienNLfuerA0cWZ4gBoEnUnChFDvKIIQQ8nQwOc1M9ZvUV avEkKcmdsNOt35MMzJI+yHgexRKthz7xboBJ7WuGZAwwW4NkfXU7jfjcTFr8cUYnY24S SC5oWfG8C+Os9iUPScN76FsDCdhAkNXpWm8pwy3j7rvbTiJGwShzz2tHduZyHs5CzdEV zU0+cjMRVdC9fDOQY6SOYYVBlieov05A3ctHOXp2LRcqcZiU7DjUasKQ2NjvSEb0ZCHF xtx/GwjQeYkxMpD7jcVBKYHhv8vTtmSSMPfNu798LdbsTizkDoheD1OjffzJX9QNxblF qQzQ== X-Gm-Message-State: AOAM533hY6EqWX5NC9xWDUmHNFXbfXFmPnIXDTwxUraV+Url2/StxhUo xPzZkd2npFKb3YnakKgd5JREyrEL+VEcoN2GZpqLgacPu3LYl3EZdmZKBX3Vs4z/GHTjSj4c/dd blzq46MavUpad6MU= X-Received: by 2002:a5d:4408:: with SMTP id z8mr8240525wrq.336.1623962548503; Thu, 17 Jun 2021 13:42:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhv/fMOkZ+DQK+slh2qtoWjvKU1m+rR+BfDAbVJrSfdPfQ/Qqpfxfxw/QW13IrV54pABvH1g== X-Received: by 2002:a5d:4408:: with SMTP id z8mr8240505wrq.336.1623962548322; Thu, 17 Jun 2021 13:42:28 -0700 (PDT) Received: from redhat.com ([77.126.22.11]) by smtp.gmail.com with ESMTPSA id o7sm6557018wro.76.2021.06.17.13.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 13:42:27 -0700 (PDT) Date: Thu, 17 Jun 2021 16:42:24 -0400 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v2 00/23] target/i386/sev: Housekeeping (OVMF + SEV-disabled binaries) Message-ID: <20210617164114-mutt-send-email-mst@kernel.org> References: <20210616204328.2611406-1-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210616204328.2611406-1-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.197, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laszlo Ersek , Brijesh Singh , Eduardo Habkost , Sergio Lopez , Connor Kuehl , Markus Armbruster , James Bottomley , Richard Henderson , qemu-devel@nongnu.org, "Dr . David Alan Gilbert" , Dov Murik , Gerd Hoffmann , Igor Mammedov , Paolo Bonzini , Eric Blake Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jun 16, 2021 at 10:43:05PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > While testing James & Dov patch: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg810571.html > I wasted some time trying to figure out how OVMF was supposed to > behave until realizing the binary I was using was built without SEV > support... Then wrote this series to help other developers to not > hit the same problem. > > Some SEV patches I was following have been queued on Eduardo's > 'x86-next' tree, so I used his tree as base, and included David and > Connor patches to reduce merge conflicts. > > Patches 1-16 are SEV related, > patches 17-23 are OVMF related. > > Special comment for Laszlo: Please don't review this version, > wait for the respin (hoping the SEV cleanup patch get accepted, > the respin will be focused on OVMF). > > Based-on: https://gitlab.com/ehabkost/qemu/-/commits/x86-next/ > Supersedes: <20210610064556.1421620-1-philmd@redhat.com> acpi things Acked-by: Michael S. Tsirkin do you want to split acpi things out so I can merge? > Connor Kuehl (1): > MAINTAINERS: Add Connor Kuehl as reviewer for AMD SEV > > Dr. David Alan Gilbert (1): > target/i386/sev: sev_get_attestation_report use g_autofree > > Philippe Mathieu-Daudé (21): > qapi/misc-target: Wrap long 'SEV Attestation Report' long lines > qapi/misc-target: Group SEV QAPI definitions > target/i386/monitor: Return QMP error when SEV is disabled in build > target/i386/cpu: Add missing 'qapi/error.h' header > target/i386/sev_i386.h: Remove unused headers > target/i386/sev: Remove sev_get_me_mask() > target/i386/sev: Mark unreachable code with g_assert_not_reached() > target/i386/sev: Restrict SEV to system emulation > target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c > target/i386/sev: Move qmp_sev_inject_launch_secret() to sev.c > target/i386/sev: Move qmp_query_sev_capabilities() to sev.c > target/i386/sev: Move qmp_query_sev_launch_measure() to sev.c > target/i386/sev: Move qmp_query_sev() & hmp_info_sev() to sev.c > monitor: Restrict 'info sev' to x86 targets > hw/i386/acpi-common: Remove unused includes > hw/i386: Rename acpi-build.c -> acpi-pc.c > hw/i386: Move pc_madt_cpu_entry() to acpi-pc.c > hw/acpi: Do not restrict ACPI core routines to x86 architecture > hw/i386: Introduce X86_FW_OVMF Kconfig symbol > hw/acpi/Kconfig: Add missing Kconfig dependencies (build error) > hw/i386/Kconfig: Add missing Kconfig dependency (runtime error) > > qapi/misc-target.json | 78 ++++++++-------- > include/hw/i386/pc.h | 1 + > include/monitor/hmp-target.h | 1 + > include/monitor/hmp.h | 1 - > target/i386/sev_i386.h | 11 --- > hw/i386/acpi-common.c | 45 ---------- > hw/i386/{acpi-build.c => acpi-pc.c} | 39 ++++++++ > hw/i386/pc_sysfw.c | 107 ---------------------- > hw/i386/pc_sysfw_ovmf-stubs.c | 26 ++++++ > hw/i386/pc_sysfw_ovmf.c | 135 ++++++++++++++++++++++++++++ > target/i386/cpu.c | 1 + > target/i386/monitor.c | 91 ------------------- > target/i386/sev-stub.c | 49 +--------- > target/i386/sev-sysemu-stub.c | 69 ++++++++++++++ > target/i386/sev.c | 130 +++++++++++++++++++++------ > MAINTAINERS | 8 ++ > hw/acpi/Kconfig | 4 + > hw/acpi/meson.build | 3 +- > hw/i386/Kconfig | 5 ++ > hw/i386/meson.build | 4 +- > target/i386/meson.build | 4 +- > 21 files changed, 443 insertions(+), 369 deletions(-) > rename hw/i386/{acpi-build.c => acpi-pc.c} (98%) > create mode 100644 hw/i386/pc_sysfw_ovmf-stubs.c > create mode 100644 hw/i386/pc_sysfw_ovmf.c > create mode 100644 target/i386/sev-sysemu-stub.c > > -- > 2.31.1 >