From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87479C2B9F4 for ; Thu, 17 Jun 2021 16:29:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0965A613B9 for ; Thu, 17 Jun 2021 16:29:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0965A613B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltutQ-0006u8-S2 for qemu-devel@archiver.kernel.org; Thu, 17 Jun 2021 12:29:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltusp-0006E5-EU for qemu-devel@nongnu.org; Thu, 17 Jun 2021 12:28:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltusk-00052w-QV for qemu-devel@nongnu.org; Thu, 17 Jun 2021 12:28:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623947320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XNI1ao1M5H8YrmLB83EplkmtKEqu2um12xyr4TCNIYo=; b=H+SqIdtf4h1br1E8llxgVaqPVAejGQdFB6+O7ad1+3EEPp1SBZQUWVu/z81Te7bNGdHSvB V7/G11Zuwfrch0LueMpykXIhmLQX7TDZb6zffKS/dvBVcOcIz/kxA1di/PXl2d043TITvC yL5zHHLgsYKMGSyDwqWmJyIMeCKb8zk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-cXj_FT82P6G9z0-wAPwxEg-1; Thu, 17 Jun 2021 12:28:37 -0400 X-MC-Unique: cXj_FT82P6G9z0-wAPwxEg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F6A9100B3AB for ; Thu, 17 Jun 2021 16:28:37 +0000 (UTC) Received: from localhost (unknown [10.43.2.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id CFE7561008; Thu, 17 Jun 2021 16:28:32 +0000 (UTC) Date: Thu, 17 Jun 2021 18:28:31 +0200 From: Igor Mammedov To: qemu-devel@nongnu.org Subject: Re: [RFC v2 1/3] tests: qtest: add qtest_has_kvm() to check if tested binary supports KVM Message-ID: <20210617182831.2a867e5e@redhat.com> In-Reply-To: <20210617100031.1380288-1-imammedo@redhat.com> References: <20210616152455.1270264-2-imammedo@redhat.com> <20210617100031.1380288-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.197, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, Paolo Bonzini , thuth@redhat.com, philmd@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 17 Jun 2021 06:00:31 -0400 Igor Mammedov wrote: Paolo, Is it acceptable to (ab)use meson like in this patch? > Currently it not possible to create tests that have KVM as a hard > requirement on a host that doesn't support KVM for tested target > binary (modulo going through the trouble of compiling out > the offending test case). > > Following scenario makes test fail when it's run on non x86 host: > qemu-system-x86_64 -enable-kvm -M q35,kernel-irqchip=on -smp 1,maxcpus=288 > > This patch introduces qtest_has_kvm() to let users check if KVM is > available in advance and skip registering non run-able test-cases. > > PS: > It's simplistic and not as versatile/precise as earlier proposed > 'query-accels' series, but it get job done for simple cases. > > on upside it's much cheaper to execute than the 'query-accels' as > it doesn't need to run QEMU for probing. > > Signed-off-by: Igor Mammedov > --- > v2: > - fix access() check. > s/access()/!access()/ > - format C array items at meson.build time, and drop > splitting targets string at runtime > > tests/qtest/libqos/libqtest.h | 7 +++++++ > meson.build | 2 ++ > tests/qtest/libqtest.c | 18 ++++++++++++++++++ > 3 files changed, 27 insertions(+) > > diff --git a/tests/qtest/libqos/libqtest.h b/tests/qtest/libqos/libqtest.h > index a68dcd79d4..bab0047117 100644 > --- a/tests/qtest/libqos/libqtest.h > +++ b/tests/qtest/libqos/libqtest.h > @@ -588,6 +588,13 @@ bool qtest_big_endian(QTestState *s); > */ > const char *qtest_get_arch(void); > > +/** > + * qtest_has_kvm: > + * > + * Returns: True if the QEMU executable under test supports KVM > + */ > +bool qtest_has_kvm(void); > + > /** > * qtest_add_func: > * @str: Test case path. > diff --git a/meson.build b/meson.build > index d2a9ce91f5..7fec4e8289 100644 > --- a/meson.build > +++ b/meson.build > @@ -75,6 +75,8 @@ elif cpu in ['mips', 'mips64'] > else > kvm_targets = [] > endif > +kvm_targets_c = '"' + '" ,"'.join(kvm_targets) + '"' > +config_host_data.set('CONFIG_KVM_TARGETS', kvm_targets_c) > > accelerator_targets = { 'CONFIG_KVM': kvm_targets } > if cpu in ['x86', 'x86_64', 'arm', 'aarch64'] > diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c > index 825b13a44c..daa6d54059 100644 > --- a/tests/qtest/libqtest.c > +++ b/tests/qtest/libqtest.c > @@ -920,6 +920,24 @@ const char *qtest_get_arch(void) > return end + 1; > } > > +bool qtest_has_kvm(void) > +{ > + int i; > + bool ret = false; > + const char *arch = qtest_get_arch(); > + const char *targets[] = { CONFIG_KVM_TARGETS }; > + > + for (i = 0; i < ARRAY_SIZE(targets); i++) { > + if (!strncmp(targets[i], arch, strlen(arch))) { > + if (!access("/dev/kvm", R_OK | W_OK)) { > + ret = true; > + break; > + } > + } > + } > + return ret; > +} > + > bool qtest_get_irq(QTestState *s, int num) > { > /* dummy operation in order to make sure irq is up to date */