From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb
Date: Sun, 20 Jun 2021 18:34:14 -0700 [thread overview]
Message-ID: <20210621013439.1791385-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210621013439.1791385-1-richard.henderson@linaro.org>
Add a generic version of the common use_goto_tb test.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/exec/translator.h | 10 ++++++++++
accel/tcg/translator.c | 11 +++++++++++
2 files changed, 21 insertions(+)
diff --git a/include/exec/translator.h b/include/exec/translator.h
index 24232ead41..dd9c06d40d 100644
--- a/include/exec/translator.h
+++ b/include/exec/translator.h
@@ -145,6 +145,16 @@ void translator_loop(const TranslatorOps *ops, DisasContextBase *db,
void translator_loop_temp_check(DisasContextBase *db);
+/**
+ * translator_use_goto_tb
+ * @db: Disassembly context
+ * @dest: target pc of the goto
+ *
+ * Return true if goto_tb is allowed between the current TB
+ * and the destination PC.
+ */
+bool translator_use_goto_tb(DisasContextBase *db, target_ulong dest);
+
/*
* Translator Load Functions
*
diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c
index 1d32732198..59804af37b 100644
--- a/accel/tcg/translator.c
+++ b/accel/tcg/translator.c
@@ -31,6 +31,17 @@ void translator_loop_temp_check(DisasContextBase *db)
}
}
+bool translator_use_goto_tb(DisasContextBase *db, target_ulong dest)
+{
+ /* Suppress goto_tb in the case of single-steping. */
+ if (db->singlestep_enabled || singlestep) {
+ return false;
+ }
+
+ /* Check for the dest on the same page as the start of the TB. */
+ return ((db->pc_first ^ dest) & TARGET_PAGE_MASK) == 0;
+}
+
void translator_loop(const TranslatorOps *ops, DisasContextBase *db,
CPUState *cpu, TranslationBlock *tb, int max_insns)
{
--
2.25.1
next prev parent reply other threads:[~2021-06-21 1:36 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 1:34 [PATCH 00/26] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` Richard Henderson [this message]
2021-06-21 6:24 ` [PATCH 01/26] " Max Filippov
2021-06-21 12:50 ` Philippe Mathieu-Daudé
2021-06-21 13:47 ` Richard Henderson
2021-06-21 15:03 ` Philippe Mathieu-Daudé
2021-06-21 13:45 ` Luis Fernando Fujita Pires
2021-06-21 1:34 ` [PATCH 02/26] target/alpha: Remove use_exit_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 03/26] target/alpha: Remove in_superpage Richard Henderson
2021-06-21 1:34 ` [PATCH 04/26] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 05/26] target/arm: " Richard Henderson
2021-06-21 10:20 ` Peter Maydell
2021-06-21 1:34 ` [PATCH 06/26] target/avr: " Richard Henderson
2021-06-21 1:34 ` [PATCH 07/26] target/avr: Mark some helpers noreturn Richard Henderson
2021-06-21 5:39 ` Michael Rolnik
2021-06-21 12:31 ` Philippe Mathieu-Daudé
2021-06-21 1:34 ` [PATCH 08/26] target/cris: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 09/26] target/hppa: " Richard Henderson
2021-06-21 1:34 ` [PATCH 10/26] target/i386: " Richard Henderson
2021-06-21 1:34 ` [PATCH 11/26] target/m68k: " Richard Henderson
2021-06-21 7:35 ` Laurent Vivier
2021-06-21 1:34 ` [PATCH 12/26] target/microblaze: " Richard Henderson
2021-06-21 1:34 ` [PATCH 13/26] target/mips: " Richard Henderson
2021-06-21 1:34 ` [PATCH 14/26] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-06-21 12:25 ` Philippe Mathieu-Daudé
2021-06-21 1:34 ` [PATCH 15/26] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 16/26] target/openrisc: " Richard Henderson
2021-06-21 1:34 ` [PATCH 17/26] target/ppc: " Richard Henderson
2021-06-21 13:45 ` Luis Fernando Fujita Pires
2021-06-21 1:34 ` [PATCH 18/26] target/riscv: " Richard Henderson
2021-06-21 22:22 ` Alistair Francis
2021-06-21 1:34 ` [PATCH 19/26] target/rx: " Richard Henderson
2021-06-21 1:34 ` [PATCH 20/26] target/s390x: " Richard Henderson
2021-06-21 1:34 ` [PATCH 21/26] target/s390x: Remove use_exit_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 22/26] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 23/26] target/sparc: " Richard Henderson
2021-06-21 9:09 ` Mark Cave-Ayland
2021-06-21 1:34 ` [PATCH 24/26] target/tricore: " Richard Henderson
2021-06-21 14:27 ` Bastian Koppelmann
2021-06-21 1:34 ` [PATCH 25/26] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-06-21 14:32 ` Bastian Koppelmann
2021-06-21 1:34 ` [PATCH 26/26] target/xtensa: Use translator_use_goto_tb Richard Henderson
2021-06-21 6:24 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621013439.1791385-2-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).