From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH 03/26] target/alpha: Remove in_superpage
Date: Sun, 20 Jun 2021 18:34:16 -0700 [thread overview]
Message-ID: <20210621013439.1791385-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210621013439.1791385-1-richard.henderson@linaro.org>
The number of links across (normal) pages using this is low,
and it will shortly violate the contract for breakpoints.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/alpha/translate.c | 24 ++----------------------
1 file changed, 2 insertions(+), 22 deletions(-)
diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index 70ba4a67c7..6ea19a1d4c 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -439,24 +439,9 @@ static DisasJumpType gen_store_conditional(DisasContext *ctx, int ra, int rb,
return DISAS_NEXT;
}
-static bool in_superpage(DisasContext *ctx, int64_t addr)
-{
-#ifndef CONFIG_USER_ONLY
- return ((ctx->tbflags & ENV_FLAG_PS_USER) == 0
- && addr >> TARGET_VIRT_ADDR_SPACE_BITS == -1
- && ((addr >> 41) & 3) == 2);
-#else
- return false;
-#endif
-}
-
static bool use_goto_tb(DisasContext *ctx, uint64_t dest)
{
#ifndef CONFIG_USER_ONLY
- /* If the destination is in the superpage, the page perms can't change. */
- if (in_superpage(ctx, dest)) {
- return true;
- }
/* Check for the dest on the same page as the start of the TB. */
return ((ctx->base.tb->pc ^ dest) & TARGET_PAGE_MASK) == 0;
#else
@@ -2916,7 +2901,7 @@ static void alpha_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
{
DisasContext *ctx = container_of(dcbase, DisasContext, base);
CPUAlphaState *env = cpu->env_ptr;
- int64_t bound, mask;
+ int64_t bound;
ctx->tbflags = ctx->base.tb->flags;
ctx->mem_idx = cpu_mmu_index(env, false);
@@ -2945,12 +2930,7 @@ static void alpha_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
ctx->lit = NULL;
/* Bound the number of insns to execute to those left on the page. */
- if (in_superpage(ctx, ctx->base.pc_first)) {
- mask = -1ULL << 41;
- } else {
- mask = TARGET_PAGE_MASK;
- }
- bound = -(ctx->base.pc_first | mask) / 4;
+ bound = -(ctx->base.pc_first | TARGET_PAGE_MASK) / 4;
ctx->base.max_insns = MIN(ctx->base.max_insns, bound);
}
--
2.25.1
next prev parent reply other threads:[~2021-06-21 1:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 1:34 [PATCH 00/26] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 01/26] " Richard Henderson
2021-06-21 6:24 ` Max Filippov
2021-06-21 12:50 ` Philippe Mathieu-Daudé
2021-06-21 13:47 ` Richard Henderson
2021-06-21 15:03 ` Philippe Mathieu-Daudé
2021-06-21 13:45 ` Luis Fernando Fujita Pires
2021-06-21 1:34 ` [PATCH 02/26] target/alpha: Remove use_exit_tb Richard Henderson
2021-06-21 1:34 ` Richard Henderson [this message]
2021-06-21 1:34 ` [PATCH 04/26] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 05/26] target/arm: " Richard Henderson
2021-06-21 10:20 ` Peter Maydell
2021-06-21 1:34 ` [PATCH 06/26] target/avr: " Richard Henderson
2021-06-21 1:34 ` [PATCH 07/26] target/avr: Mark some helpers noreturn Richard Henderson
2021-06-21 5:39 ` Michael Rolnik
2021-06-21 12:31 ` Philippe Mathieu-Daudé
2021-06-21 1:34 ` [PATCH 08/26] target/cris: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 09/26] target/hppa: " Richard Henderson
2021-06-21 1:34 ` [PATCH 10/26] target/i386: " Richard Henderson
2021-06-21 1:34 ` [PATCH 11/26] target/m68k: " Richard Henderson
2021-06-21 7:35 ` Laurent Vivier
2021-06-21 1:34 ` [PATCH 12/26] target/microblaze: " Richard Henderson
2021-06-21 1:34 ` [PATCH 13/26] target/mips: " Richard Henderson
2021-06-21 1:34 ` [PATCH 14/26] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-06-21 12:25 ` Philippe Mathieu-Daudé
2021-06-21 1:34 ` [PATCH 15/26] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 16/26] target/openrisc: " Richard Henderson
2021-06-21 1:34 ` [PATCH 17/26] target/ppc: " Richard Henderson
2021-06-21 13:45 ` Luis Fernando Fujita Pires
2021-06-21 1:34 ` [PATCH 18/26] target/riscv: " Richard Henderson
2021-06-21 22:22 ` Alistair Francis
2021-06-21 1:34 ` [PATCH 19/26] target/rx: " Richard Henderson
2021-06-21 1:34 ` [PATCH 20/26] target/s390x: " Richard Henderson
2021-06-21 1:34 ` [PATCH 21/26] target/s390x: Remove use_exit_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 22/26] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 23/26] target/sparc: " Richard Henderson
2021-06-21 9:09 ` Mark Cave-Ayland
2021-06-21 1:34 ` [PATCH 24/26] target/tricore: " Richard Henderson
2021-06-21 14:27 ` Bastian Koppelmann
2021-06-21 1:34 ` [PATCH 25/26] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-06-21 14:32 ` Bastian Koppelmann
2021-06-21 1:34 ` [PATCH 26/26] target/xtensa: Use translator_use_goto_tb Richard Henderson
2021-06-21 6:24 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621013439.1791385-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).