qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Vivek Kasireddy <vivek.kasireddy@intel.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3 3/5] ui: Create sync objects and fences only for blobs
Date: Wed, 23 Jun 2021 10:15:15 +0200	[thread overview]
Message-ID: <20210623081515.ezdchomanr73wrp5@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210621192425.1188442-4-vivek.kasireddy@intel.com>

  Hi,

>      dmabuf->buf.fd = res->dmabuf_fd;
> +    dmabuf->buf.blob = true;

Do you actually need the 'blob' field?
I think checking 'fd' instead should work too.

take care,
  Gerd



  reply	other threads:[~2021-06-23  8:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 19:24 [PATCH v3 0/5] virtio-gpu: Add a default synchronization mechanism for blobs Vivek Kasireddy
2021-06-21 19:24 ` [PATCH v3 1/5] ui/gtk: Create a common release_dmabuf helper Vivek Kasireddy
2021-06-21 19:24 ` [PATCH v3 2/5] ui/egl: Add egl helpers to help with synchronization Vivek Kasireddy
2021-06-23  8:17   ` Gerd Hoffmann
2021-06-21 19:24 ` [PATCH v3 3/5] ui: Create sync objects and fences only for blobs Vivek Kasireddy
2021-06-23  8:15   ` Gerd Hoffmann [this message]
2021-06-23 19:11     ` Kasireddy, Vivek
2021-06-24  8:39       ` Gerd Hoffmann
2021-06-24 18:34         ` Kasireddy, Vivek
2021-06-21 19:24 ` [PATCH v3 4/5] ui/gtk-egl: Wait for the draw signal for dmabuf blobs Vivek Kasireddy
2021-06-23  8:17   ` Gerd Hoffmann
2021-06-21 19:24 ` [PATCH v3 5/5] virtio-gpu: Add gl_flushed callback Vivek Kasireddy
2021-06-23  8:18   ` Gerd Hoffmann
2021-06-21 19:48 ` [PATCH v3 0/5] virtio-gpu: Add a default synchronization mechanism for blobs no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210623081515.ezdchomanr73wrp5@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).