From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A33EC49EA6 for ; Sat, 26 Jun 2021 06:48:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 044336141F for ; Sat, 26 Jun 2021 06:48:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 044336141F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lx27Y-00089n-3G for qemu-devel@archiver.kernel.org; Sat, 26 Jun 2021 02:48:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lx1vx-0002ZA-IQ for qemu-devel@nongnu.org; Sat, 26 Jun 2021 02:36:53 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:41833) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lx1vs-0000RE-DT for qemu-devel@nongnu.org; Sat, 26 Jun 2021 02:36:53 -0400 Received: by mail-pj1-x102f.google.com with SMTP id m15-20020a17090a5a4fb029016f385ffad0so6861759pji.0 for ; Fri, 25 Jun 2021 23:36:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uxQeR//xqY+LsX6pm6SBoWME/fdGKFQJm9ucGcJi4j0=; b=aeiArkHxqTHJZOLaMIWNzDAlAQWAD29fdb9qDhu6FbPXC1sOaIQ/pTbcYRbfUUE7KX b8/mi7IdRLwj5+oIgHrXhcOUPL/2dDcwSWx1hJLHIrBJ3uVjHnbyWKomuHmK/m/t76dl G5pTrUGvjpY0IdFmU4JEz69xrqAEInwQqa7x29bbYHfs3fmgFnjtCJGzlwe1EJd1glj6 z7/mK3UaXIElPSR4mMYtqFPJ6dvqpNXnufO+2ATS7rv0mkKZpFV7tJsfCSgmQ1fjCBbu eKvJt1d6uUK+Q+7zl6i2g9RFsHvjROzqqc050+KU+l2ZY/Bdzwhel+CJVQSJFfvQKZbL QQCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uxQeR//xqY+LsX6pm6SBoWME/fdGKFQJm9ucGcJi4j0=; b=Ahgga1wljxkZXgRIiSwfY152Ybzju2AY2tmdYK+Rpr/XC0s/bt9aJZxnWQBwTSY5sl BIvtFVXXU/xEHK9gROLH2qYj2AXlKbYqYQUGFE1fuA5AtrRvZtyvRo1JPvG1sFLk5M5Q cCi1057/Q5dBmmvdisd01nydmYfvAD/XxBCKMJzVlr+7/M6oMex6Cod+te6vkhnfCowj UmGMRjplawWtkvM/3v4t2yqXDNsEU0SImP+1R5R9yZWY7PnLH9FPxEHz43blE8nnBgxX FnZqJLSQe+U4Usuf1Vw7u/QqHEiM4CdKoXEYCgPpLMfj/S5oPAQQrl414lNJ8vwYB09o 8URg== X-Gm-Message-State: AOAM530w++kuQl1UTrOWa8ijrKR76ZbxLU5hY2Sd19ng81TpEAx0K+nF WCqxAyzLgrqUjxtTRqvXopKu+S83Z2xk7A== X-Google-Smtp-Source: ABdhPJzmYt6q0FlTepizVXQ/y/Ld1zBCFtJUL19UqcNNPBnRGe/IZk4yyCPv7EsYlxpwlUW5BcUaPQ== X-Received: by 2002:a17:90a:31ca:: with SMTP id j10mr15429030pjf.53.1624689407141; Fri, 25 Jun 2021 23:36:47 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id v9sm7724201pgq.54.2021.06.25.23.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 23:36:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 24/29] target/i386: Improve bswap translation Date: Fri, 25 Jun 2021 23:36:26 -0700 Message-Id: <20210626063631.2411938-25-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210626063631.2411938-1-richard.henderson@linaro.org> References: <20210626063631.2411938-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Use a break instead of an ifdefed else. There's no need to move the values through s->T0. Remove TCG_BSWAP_IZ and the preceding zero-extension. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index e8a9dcd21a..b21873ed23 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -7195,17 +7195,11 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu) reg = (b & 7) | REX_B(s); #ifdef TARGET_X86_64 if (dflag == MO_64) { - gen_op_mov_v_reg(s, MO_64, s->T0, reg); - tcg_gen_bswap64_i64(s->T0, s->T0); - gen_op_mov_reg_v(s, MO_64, reg, s->T0); - } else -#endif - { - gen_op_mov_v_reg(s, MO_32, s->T0, reg); - tcg_gen_ext32u_tl(s->T0, s->T0); - tcg_gen_bswap32_tl(s->T0, s->T0, TCG_BSWAP_IZ | TCG_BSWAP_OZ); - gen_op_mov_reg_v(s, MO_32, reg, s->T0); + tcg_gen_bswap64_i64(cpu_regs[reg], cpu_regs[reg]); + break; } +#endif + tcg_gen_bswap32_tl(cpu_regs[reg], cpu_regs[reg], TCG_BSWAP_OZ); break; case 0xd6: /* salc */ if (CODE64(s)) -- 2.25.1