From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH v2 03/28] target/alpha: Remove in_superpage
Date: Wed, 30 Jun 2021 11:32:01 -0700 [thread overview]
Message-ID: <20210630183226.3290849-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210630183226.3290849-1-richard.henderson@linaro.org>
The number of links across (normal) pages using this is low,
and it will shortly violate the contract for breakpoints.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/alpha/translate.c | 24 ++----------------------
1 file changed, 2 insertions(+), 22 deletions(-)
diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index aaedf78116..8fa00a79d1 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -439,24 +439,9 @@ static DisasJumpType gen_store_conditional(DisasContext *ctx, int ra, int rb,
return DISAS_NEXT;
}
-static bool in_superpage(DisasContext *ctx, int64_t addr)
-{
-#ifndef CONFIG_USER_ONLY
- return ((ctx->tbflags & ENV_FLAG_PS_USER) == 0
- && addr >> TARGET_VIRT_ADDR_SPACE_BITS == -1
- && ((addr >> 41) & 3) == 2);
-#else
- return false;
-#endif
-}
-
static bool use_goto_tb(DisasContext *ctx, uint64_t dest)
{
#ifndef CONFIG_USER_ONLY
- /* If the destination is in the superpage, the page perms can't change. */
- if (in_superpage(ctx, dest)) {
- return true;
- }
/* Check for the dest on the same page as the start of the TB. */
return ((ctx->base.tb->pc ^ dest) & TARGET_PAGE_MASK) == 0;
#else
@@ -2991,7 +2976,7 @@ static void alpha_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
{
DisasContext *ctx = container_of(dcbase, DisasContext, base);
CPUAlphaState *env = cpu->env_ptr;
- int64_t bound, mask;
+ int64_t bound;
ctx->tbflags = ctx->base.tb->flags;
ctx->mem_idx = cpu_mmu_index(env, false);
@@ -3020,12 +3005,7 @@ static void alpha_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cpu)
ctx->lit = NULL;
/* Bound the number of insns to execute to those left on the page. */
- if (in_superpage(ctx, ctx->base.pc_first)) {
- mask = -1ULL << 41;
- } else {
- mask = TARGET_PAGE_MASK;
- }
- bound = -(ctx->base.pc_first | mask) / 4;
+ bound = -(ctx->base.pc_first | TARGET_PAGE_MASK) / 4;
ctx->base.max_insns = MIN(ctx->base.max_insns, bound);
}
--
2.25.1
next prev parent reply other threads:[~2021-06-30 18:42 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 18:31 [PATCH v2 00/28] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
2021-06-30 18:31 ` [PATCH v2 01/28] " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 02/28] target/alpha: Remove use_exit_tb Richard Henderson
2021-07-08 12:34 ` Peter Maydell
2021-06-30 18:32 ` Richard Henderson [this message]
2021-07-08 12:35 ` [PATCH v2 03/28] target/alpha: Remove in_superpage Peter Maydell
2021-06-30 18:32 ` [PATCH v2 04/28] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:29 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 05/28] target/arm: Use gen_jmp for ISB and SB Richard Henderson
2021-07-08 12:05 ` Peter Maydell
2021-07-08 16:04 ` Richard Henderson
2021-07-08 16:11 ` Peter Maydell
2021-07-08 16:17 ` Richard Henderson
2021-07-08 17:47 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 06/28] target/arm: Use translator_use_goto_tb for aarch64 Richard Henderson
2021-07-08 12:08 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 07/28] target/arm: Use translator_use_goto_tb for aarch32 Richard Henderson
2021-07-08 12:14 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 08/28] target/avr: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:28 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 09/28] target/avr: Mark some helpers noreturn Richard Henderson
2021-06-30 18:32 ` [PATCH v2 10/28] target/cris: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:27 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 11/28] target/hppa: " Richard Henderson
2021-07-08 12:26 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 12/28] target/i386: " Richard Henderson
2021-07-08 12:26 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 13/28] target/m68k: " Richard Henderson
2021-07-08 12:22 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 14/28] target/microblaze: " Richard Henderson
2021-07-08 12:21 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 15/28] target/mips: " Richard Henderson
2021-07-08 12:18 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 16/28] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-06-30 18:32 ` [PATCH v2 17/28] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:17 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 18/28] target/openrisc: " Richard Henderson
2021-07-07 20:59 ` Stafford Horne
2021-06-30 18:32 ` [PATCH v2 19/28] target/ppc: " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 20/28] target/riscv: " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 21/28] target/rx: " Richard Henderson
2021-07-08 12:17 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 22/28] target/s390x: " Richard Henderson
2021-07-01 7:42 ` David Hildenbrand
2021-06-30 18:32 ` [PATCH v2 23/28] target/s390x: Remove use_exit_tb Richard Henderson
2021-07-01 7:44 ` David Hildenbrand
2021-06-30 18:32 ` [PATCH v2 24/28] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-07-08 12:16 ` Peter Maydell
2021-06-30 18:32 ` [PATCH v2 25/28] target/sparc: " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 26/28] target/tricore: " Richard Henderson
2021-06-30 18:32 ` [PATCH v2 27/28] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-06-30 18:32 ` [PATCH v2 28/28] target/xtensa: Use translator_use_goto_tb Richard Henderson
2021-07-07 21:41 ` [PATCH v2 00/28] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630183226.3290849-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).