From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Eric Blake <eblake@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
"Niteesh G . S ." <niteesh.gs@gmail.com>,
Willian Rampazzo <wrampazz@redhat.com>,
Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>
Subject: [PATCH 04/20] python/aqmp: add error classes
Date: Thu, 1 Jul 2021 00:12:57 -0400 [thread overview]
Message-ID: <20210701041313.1696009-5-jsnow@redhat.com> (raw)
In-Reply-To: <20210701041313.1696009-1-jsnow@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/aqmp/__init__.py | 7 +++
python/qemu/aqmp/error.py | 97 ++++++++++++++++++++++++++++++++++++
2 files changed, 104 insertions(+)
create mode 100644 python/qemu/aqmp/error.py
diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py
index 4c713b3ccf..8e955d784d 100644
--- a/python/qemu/aqmp/__init__.py
+++ b/python/qemu/aqmp/__init__.py
@@ -21,7 +21,14 @@
# This work is licensed under the terms of the GNU GPL, version 2. See
# the COPYING file in the top-level directory.
+from .error import AQMPError, MultiException
+
# The order of these fields impact the Sphinx documentation order.
__all__ = (
+ # Exceptions
+ 'AQMPError',
+
+ # Niche topics
+ 'MultiException',
)
diff --git a/python/qemu/aqmp/error.py b/python/qemu/aqmp/error.py
new file mode 100644
index 0000000000..126f77bb5c
--- /dev/null
+++ b/python/qemu/aqmp/error.py
@@ -0,0 +1,97 @@
+"""
+AQMP Error Classes
+
+This package seeks to provide semantic error classes that are intended
+to be used directly by clients when they would like to handle particular
+semantic failures (e.g. "failed to connect") without needing to know the
+enumeration of possible reasons for that failure.
+
+AQMPError serves as the ancestor for *almost* all exceptions raised by
+this package, and is suitable for use in handling semantic errors from
+this library. In most cases, individual public methods will attempt to
+catch and re-encapsulate various exceptions to provide a semantic
+error-handling interface.
+
+.. caution::
+
+ The only exception that is not an `AQMPError` is
+ `MultiException`. It is special, and used to encapsulate one-or-more
+ exceptions of an arbitrary kind; this exception MAY be raised on
+ `disconnect()` when there are two or more exceptions from the AQMP
+ event loop to report back to the caller.
+
+ Every pain has been taken to prevent this circumstance but in
+ certain cases these exceptions may occasionally be (unfortunately)
+ visible. See `MultiException` and `AsyncProtocol.disconnect()` for
+ more details.
+
+
+.. admonition:: AQMP Exception Hierarchy Reference
+
+ | `Exception`
+ | +-- `MultiException`
+ | +-- `AQMPError`
+ | +-- `ConnectError`
+ | +-- `StateError`
+ | +-- `ExecInterruptedError`
+ | +-- `ExecuteError`
+ | +-- `ListenerError`
+ | +-- `ProtocolError`
+ | +-- `DeserializationError`
+ | +-- `UnexpectedTypeError`
+ | +-- `ServerParseError`
+ | +-- `BadReplyError`
+ | +-- `GreetingError`
+ | +-- `NegotiationError`
+"""
+
+from typing import Iterable, Iterator, List
+
+
+class AQMPError(Exception):
+ """Abstract error class for all errors originating from this package."""
+
+
+class ProtocolError(AQMPError):
+ """
+ Abstract error class for protocol failures.
+
+ Semantically, these errors are generally the fault of either the
+ protocol server or as a result of a bug in this this library.
+
+ :param error_message: Human-readable string describing the error.
+ """
+ def __init__(self, error_message: str):
+ super().__init__(error_message)
+ #: Human-readable error message, without any prefix.
+ self.error_message: str = error_message
+
+
+class MultiException(Exception):
+ """
+ Used for multiplexing exceptions.
+
+ This exception is used in the case that errors were encountered in both the
+ Reader and Writer tasks, and we must raise more than one.
+
+ PEP 0654 seeks to remedy this clunky infrastructure, but it will not be
+ available for quite some time -- possibly Python 3.11 or even later.
+
+ :param exceptions: An iterable of `BaseException` objects.
+ """
+ def __init__(self, exceptions: Iterable[BaseException]):
+ super().__init__(exceptions)
+ self._exceptions: List[BaseException] = list(exceptions)
+
+ def __str__(self) -> str:
+ ret = "------------------------------\n"
+ ret += "Multiple Exceptions occurred:\n"
+ ret += "\n"
+ for i, exc in enumerate(self._exceptions):
+ ret += f"{i}) {str(exc)}\n"
+ ret += "\n"
+ ret += "-----------------------------\n"
+ return ret
+
+ def __iter__(self) -> Iterator[BaseException]:
+ return iter(self._exceptions)
--
2.31.1
next prev parent reply other threads:[~2021-07-01 4:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 4:12 [PATCH 00/20] python: introduce Asynchronous QMP package John Snow
2021-07-01 4:12 ` [PATCH 01/20] python/pylint: Add exception for TypeVar names ('T') John Snow
2021-07-01 4:12 ` [PATCH 02/20] python/pylint: disable too-many-function-args John Snow
2021-07-01 4:12 ` [PATCH 03/20] python/aqmp: add asynchronous QMP (AQMP) subpackage John Snow
2021-07-01 4:12 ` John Snow [this message]
2021-07-01 4:12 ` [PATCH 05/20] python/aqmp: add asyncio compatibility wrappers John Snow
2021-07-01 4:12 ` [PATCH 06/20] python/aqmp: add generic async message-based protocol support John Snow
2021-07-01 4:13 ` [PATCH 07/20] python/aqmp: add runstate state machine to AsyncProtocol John Snow
2021-07-01 4:13 ` [PATCH 08/20] python/aqmp: add logging " John Snow
2021-07-01 4:13 ` [PATCH 09/20] python/aqmp: add AsyncProtocol.accept() method John Snow
2021-07-01 4:13 ` [PATCH 10/20] python/aqmp: add _cb_inbound and _cb_inbound logging hooks John Snow
2021-07-01 4:13 ` [PATCH 11/20] python/aqmp: add AsyncProtocol._readline() method John Snow
2021-07-01 4:13 ` [PATCH 12/20] python/aqmp: add QMP Message format John Snow
2021-07-07 14:52 ` Niteesh G. S.
2021-07-08 16:50 ` John Snow
2021-07-01 4:13 ` [PATCH 13/20] python/aqmp: add well-known QMP object models John Snow
2021-07-01 4:13 ` [PATCH 14/20] python/aqmp: add QMP event support John Snow
2021-07-01 4:13 ` [PATCH 15/20] python/aqmp: add QMP protocol support John Snow
2021-07-01 4:13 ` [PATCH 16/20] python/aqmp: Add message routing to QMP protocol John Snow
2021-07-01 4:13 ` [PATCH 17/20] python/aqmp: add execute() interfaces John Snow
2021-07-01 4:13 ` [PATCH 18/20] python/aqmp: add _raw() execution interface John Snow
2021-07-01 4:13 ` [PATCH 19/20] python/aqmp: add asyncio_run compatibility wrapper John Snow
2021-07-01 4:13 ` [PATCH 20/20] python/aqmp: add scary message John Snow
2021-07-05 13:19 ` [PATCH 00/20] python: introduce Asynchronous QMP package Stefan Hajnoczi
2021-07-08 13:24 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210701041313.1696009-5-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=niteesh.gs@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).