From: Bin Meng <bmeng.cn@gmail.com>
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: Bin Meng <bin.meng@windriver.com>,
Christina Wang <christina.wang@windriver.com>,
Markus Carlstedt <markus.carlstedt@windriver.com>
Subject: [PATCH v2 3/3] hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor
Date: Fri, 2 Jul 2021 17:24:27 +0800 [thread overview]
Message-ID: <20210702092427.1323667-3-bmeng.cn@gmail.com> (raw)
In-Reply-To: <20210702092427.1323667-1-bmeng.cn@gmail.com>
From: Christina Wang <christina.wang@windriver.com>
In the legacy RX descriptor mode, VLAN tag was saved to d->special
by e1000e_build_rx_metadata() in e1000e_write_lgcy_rx_descr(), but
it was then zeroed out again at the end of the call, which is wrong.
Fixes: c89d416a2b0f ("e1000e: Don't zero out buffer address in rx descriptor")
Reported-by: Markus Carlstedt <markus.carlstedt@windriver.com>
Signed-off-by: Christina Wang <christina.wang@windriver.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
(no changes since v1)
hw/net/e1000e_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index 38b3e3b784..738c7169e4 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -1286,7 +1286,6 @@ e1000e_write_lgcy_rx_descr(E1000ECore *core, uint8_t *desc,
&d->special);
d->errors = (uint8_t) (le32_to_cpu(status_flags) >> 24);
d->status = (uint8_t) le32_to_cpu(status_flags);
- d->special = 0;
}
static inline void
--
2.25.1
next prev parent reply other threads:[~2021-07-02 9:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 9:24 [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register Bin Meng
2021-07-02 9:24 ` [PATCH v2 2/3] hw/net: e1000e: " Bin Meng
2021-07-02 9:24 ` Bin Meng [this message]
2021-07-05 4:21 ` [PATCH v2 1/3] hw/net: e1000: " Jason Wang
2021-07-05 5:57 ` Bin Meng
2021-07-12 23:06 ` Bin Meng
2021-07-13 7:03 ` Jason Wang
2021-07-13 8:36 ` Bin Meng
2021-07-13 9:02 ` Jason Wang
2021-07-13 9:11 ` Bin Meng
2021-07-14 3:10 ` Jason Wang
2021-07-14 3:42 ` Bin Meng
2021-07-14 4:53 ` Jason Wang
2021-07-14 6:04 ` Bin Meng
2021-07-14 8:40 ` Jason Wang
2021-07-14 9:05 ` Bin Meng
2021-07-14 9:17 ` Jason Wang
2021-07-14 9:00 ` Peter Maydell
2021-07-14 9:14 ` Bin Meng
2021-07-14 9:24 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702092427.1323667-3-bmeng.cn@gmail.com \
--to=bmeng.cn@gmail.com \
--cc=bin.meng@windriver.com \
--cc=christina.wang@windriver.com \
--cc=jasowang@redhat.com \
--cc=markus.carlstedt@windriver.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).