qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yanan Wang <wangyanan55@huawei.com>
To: <qemu-devel@nongnu.org>
Cc: "Andrew Jones" <drjones@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	wanghaibin.wang@huawei.com, "Yanan Wang" <wangyanan55@huawei.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	yuzenghui@huawei.com, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: [RFC PATCH 5/6] pc/machine: Disallow any configuration of dies for non-PC machines
Date: Fri, 2 Jul 2021 18:07:38 +0800	[thread overview]
Message-ID: <20210702100739.13672-6-wangyanan55@huawei.com> (raw)
In-Reply-To: <20210702100739.13672-1-wangyanan55@huawei.com>

Since a machine type does not support topology parameter of dies,
it's probably more reasonable to reject any explicit specification
to avoid possible confuse, including "dies=0" and "dies=1" although
they won't affect the calculation of non-PC machines.

Also a comment of struct SMPConfiguration is fixed.

Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
---
 hw/core/machine.c | 2 +-
 qapi/machine.json | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/core/machine.c b/hw/core/machine.c
index 58882835be..55785feee2 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -747,7 +747,7 @@ static void smp_parse(MachineState *ms, SMPConfiguration *config, Error **errp)
     unsigned threads = config->has_threads ? config->threads : 0;
     unsigned maxcpus = config->has_maxcpus ? config->maxcpus : 0;
 
-    if (config->has_dies && config->dies != 0 && config->dies != 1) {
+    if (config->has_dies) {
         error_setg(errp, "dies not supported by this machine's CPU topology");
     }
 
diff --git a/qapi/machine.json b/qapi/machine.json
index c3210ee1fb..253f84abf6 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -1297,7 +1297,7 @@
 #
 # @dies: number of dies per socket in the CPU topology
 #
-# @cores: number of cores per thread in the CPU topology
+# @cores: number of cores per die in the CPU topology
 #
 # @threads: number of threads per core in the CPU topology
 #
-- 
2.19.1



  parent reply	other threads:[~2021-07-02 10:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 10:07 [RFC PATCH 0/6] machine: smp parsing fixes and improvement Yanan Wang
2021-07-02 10:07 ` [RFC PATCH 1/6] machine: Set the value of maxcpus to match cpus if specified as zero Yanan Wang
2021-07-12 14:57   ` Andrew Jones
2021-07-12 15:27     ` Daniel P. Berrangé
2021-07-02 10:07 ` [RFC PATCH 2/6] machine: Perform zero-check for the computed value of sockets Yanan Wang
2021-07-12 15:00   ` Andrew Jones
2021-07-12 15:30     ` Daniel P. Berrangé
2021-07-13  6:56       ` wangyanan (Y)
2021-07-02 10:07 ` [RFC PATCH 3/6] pc/machine: Perform zero-check for the value of -smp dies Yanan Wang
2021-07-12 15:04   ` Andrew Jones
2021-07-12 15:05     ` Andrew Jones
2021-07-12 15:27       ` Andrew Jones
2021-07-13  6:46         ` wangyanan (Y)
2021-07-02 10:07 ` [RFC PATCH 4/6] machine: Uniformly use maxcpus to calculate the missing values Yanan Wang
2021-07-12 15:25   ` Andrew Jones
2021-07-13  7:25     ` wangyanan (Y)
2021-07-13  7:49   ` wangyanan (Y)
2021-07-02 10:07 ` Yanan Wang [this message]
2021-07-02 10:18   ` [RFC PATCH 5/6] pc/machine: Disallow any configuration of dies for non-PC machines Daniel P. Berrangé
2021-07-05  9:03     ` wangyanan (Y)
2021-07-02 10:07 ` [RFC PATCH 6/6] machine: Tweak the order of topology members in struct CpuTopology Yanan Wang
2021-07-12 15:29   ` Andrew Jones
2021-07-12 19:46   ` Pankaj Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210702100739.13672-6-wangyanan55@huawei.com \
    --to=wangyanan55@huawei.com \
    --cc=berrange@redhat.com \
    --cc=drjones@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wanghaibin.wang@huawei.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).