From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, mreitz@redhat.com,
vsementsov@virtuozzo.com, den@openvz.org, jsnow@redhat.com
Subject: [PATCH 00/14] iotests: support zstd
Date: Mon, 5 Jul 2021 12:15:35 +0300 [thread overview]
Message-ID: <20210705091549.178335-1-vsementsov@virtuozzo.com> (raw)
Hi all!
These series makes all test pass with
IMGOPTS='compression_type=zstd'
Also, python iotests start to support IMGOPTS (they didn't before).
Also, tests works if enable compression type zstd by default. There is
no such config option currently, probably it will appear in future or
we'll go some another way (like external config file, like
/etc/qemu.conf). For now you may test with a simple patch like:
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -3539,6 +3539,11 @@ qcow2_co_create(BlockdevCreateOptions *create_options, Error **errp)
goto out;
}
}
+
+ if (!qcow2_opts->has_compression_type && version >= 3) {
+ qcow2_opts->has_compression_type = true;
+ qcow2_opts->compression_type = QCOW2_COMPRESSION_TYPE_ZSTD;
+ }
if (qcow2_opts->has_compression_type &&
qcow2_opts->compression_type != QCOW2_COMPRESSION_TYPE_ZLIB) {
We want to use zstd compression type by default in Virtuozzo 8. This is
the first step, which is good anyway: improve iotests.
Vladimir Sementsov-Ogievskiy (14):
iotests.py: img_info_log(): rename imgopts argument
iotests.py: qemu_img*("create"): support
IMGOPTS='compression_type=zstd'
iotest 303: explicit compression type
iotest 065: explicit compression type
iotests.py: filter compression type out
iotest 302: use img_info_log() helper
qcow2: simple case support for downgrading of qcow2 images with zstd
iotests/common.rc: _make_test_img(): smarter compressiont_type
handling
iotests/common.rc: introduce _qcow2_dump_header helper
iotests: massive use _qcow2_dump_header
iotests: bash tests: filter compression type
iotests 60: more accurate set dirty bit in qcow2 header
iotest 39: use _qcow2_dump_header
iotest 214: explicit compression type
block/qcow2.c | 58 ++++++++++++++++++++++++++-
tests/qemu-iotests/031 | 6 +--
tests/qemu-iotests/036 | 6 +--
tests/qemu-iotests/039 | 22 +++++------
tests/qemu-iotests/060 | 22 +++++------
tests/qemu-iotests/060.out | 2 +-
tests/qemu-iotests/061 | 36 ++++++++---------
tests/qemu-iotests/061.out | 12 +++---
tests/qemu-iotests/065 | 14 +++----
tests/qemu-iotests/082.out | 14 +++----
tests/qemu-iotests/137 | 2 +-
tests/qemu-iotests/198.out | 4 +-
tests/qemu-iotests/206.out | 10 ++---
tests/qemu-iotests/210 | 8 ++--
tests/qemu-iotests/214 | 2 +-
tests/qemu-iotests/242.out | 10 ++---
tests/qemu-iotests/255.out | 8 ++--
tests/qemu-iotests/274.out | 68 ++++++++++++++++----------------
tests/qemu-iotests/280.out | 2 +-
tests/qemu-iotests/287 | 8 ++--
tests/qemu-iotests/302 | 3 +-
tests/qemu-iotests/302.out | 7 ++--
tests/qemu-iotests/303 | 25 +++++++-----
tests/qemu-iotests/303.out | 30 +++++++++++++-
tests/qemu-iotests/common.filter | 7 ++++
tests/qemu-iotests/common.rc | 30 ++++++++++++++
tests/qemu-iotests/iotests.py | 66 +++++++++++++++++++++++++++++--
27 files changed, 333 insertions(+), 149 deletions(-)
--
2.29.2
next reply other threads:[~2021-07-05 9:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 9:15 Vladimir Sementsov-Ogievskiy [this message]
2021-07-05 9:15 ` [PATCH 01/14] iotests.py: img_info_log(): rename imgopts argument Vladimir Sementsov-Ogievskiy
2021-07-16 10:07 ` Max Reitz
2021-07-05 9:15 ` [PATCH 02/14] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd' Vladimir Sementsov-Ogievskiy
2021-07-16 10:07 ` Max Reitz
2021-07-16 10:34 ` Vladimir Sementsov-Ogievskiy
2021-07-19 12:58 ` Vladimir Sementsov-Ogievskiy
2021-07-19 13:51 ` Vladimir Sementsov-Ogievskiy
2021-07-05 9:15 ` [PATCH 03/14] iotest 303: explicit compression type Vladimir Sementsov-Ogievskiy
2021-07-16 10:38 ` Max Reitz
2021-07-05 9:15 ` [PATCH 04/14] iotest 065: " Vladimir Sementsov-Ogievskiy
2021-07-16 11:01 ` Max Reitz
2021-07-05 9:15 ` [PATCH 05/14] iotests.py: filter compression type out Vladimir Sementsov-Ogievskiy
2021-07-16 11:15 ` Max Reitz
2021-07-16 11:32 ` Vladimir Sementsov-Ogievskiy
2021-07-05 9:15 ` [PATCH 06/14] iotest 302: use img_info_log() helper Vladimir Sementsov-Ogievskiy
2021-07-05 11:02 ` Vladimir Sementsov-Ogievskiy
2021-07-16 11:39 ` Max Reitz
2021-07-16 12:32 ` Vladimir Sementsov-Ogievskiy
2021-07-05 9:15 ` [PATCH 07/14] qcow2: simple case support for downgrading of qcow2 images with zstd Vladimir Sementsov-Ogievskiy
2021-07-16 12:08 ` Max Reitz
2021-07-05 9:15 ` [PATCH 08/14] iotests/common.rc: _make_test_img(): smarter compressiont_type handling Vladimir Sementsov-Ogievskiy
2021-07-16 12:38 ` Max Reitz
2021-07-16 14:24 ` Vladimir Sementsov-Ogievskiy
2021-07-16 14:46 ` Max Reitz
2021-07-05 9:15 ` [PATCH 09/14] iotests/common.rc: introduce _qcow2_dump_header helper Vladimir Sementsov-Ogievskiy
2021-07-16 12:56 ` Max Reitz
2021-07-05 9:15 ` [PATCH 10/14] iotests: massive use _qcow2_dump_header Vladimir Sementsov-Ogievskiy
2021-07-16 13:04 ` Max Reitz
2021-07-05 9:15 ` [PATCH 11/14] iotests: bash tests: filter compression type Vladimir Sementsov-Ogievskiy
2021-07-16 13:17 ` Max Reitz
2021-07-16 14:35 ` Vladimir Sementsov-Ogievskiy
2021-07-05 9:15 ` [PATCH 12/14] iotests 60: more accurate set dirty bit in qcow2 header Vladimir Sementsov-Ogievskiy
2021-07-16 13:20 ` Max Reitz
2021-07-05 9:15 ` [PATCH 13/14] iotest 39: use _qcow2_dump_header Vladimir Sementsov-Ogievskiy
2021-07-16 13:31 ` Max Reitz
2021-07-05 9:15 ` [PATCH 14/14] iotest 214: explicit compression type Vladimir Sementsov-Ogievskiy
2021-07-16 13:35 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705091549.178335-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).