From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Peter Xu" <peterx@redhat.com>, "Wei Wang" <wei.w.wang@intel.com>,
"Alexander Duyck" <alexander.duyck@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v1 0/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT
Date: Wed, 7 Jul 2021 16:06:53 +0200 [thread overview]
Message-ID: <20210707140655.30982-1-david@redhat.com> (raw)
Working on getting migration for virtio-mem completely right [1] I realized
that virtio-balloon with VIRTIO_BALLOON_F_FREE_PAGE_HINT paired with
postcopy might be shaky. Actually testing it, I directly found two issues,
one of both being far from trivial to fix.
Let's disallow postcopy with "free-page-hint=on".
[1] https://lkml.kernel.org/r/20210616162940.28630-1-david@redhat.com
David Hildenbrand (2):
migration/postcopy-ram: define type for "struct PostcopyNotifyData"
virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT
hw/virtio/vhost-user.c | 2 +-
hw/virtio/virtio-balloon.c | 26 ++++++++++++++++++++++++++
include/hw/virtio/virtio-balloon.h | 1 +
migration/postcopy-ram.c | 2 +-
migration/postcopy-ram.h | 4 ++--
5 files changed, 31 insertions(+), 4 deletions(-)
--
2.31.1
next reply other threads:[~2021-07-07 14:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 14:06 David Hildenbrand [this message]
2021-07-07 14:06 ` [PATCH v1 1/2] migration/postcopy-ram: define type for "struct PostcopyNotifyData" David Hildenbrand
2021-07-07 20:30 ` Pankaj Gupta
2021-07-07 14:06 ` [PATCH v1 2/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT David Hildenbrand
2021-07-07 18:02 ` Peter Xu
2021-07-07 18:57 ` David Hildenbrand
2021-07-07 19:07 ` Michael S. Tsirkin
2021-07-07 20:08 ` Peter Xu
2021-07-07 21:22 ` Alexander Duyck
2021-07-07 22:40 ` Peter Xu
2021-07-08 7:14 ` David Hildenbrand
2021-07-08 7:23 ` David Hildenbrand
2021-07-07 19:05 ` Michael S. Tsirkin
2021-07-07 19:14 ` David Hildenbrand
2021-07-07 19:19 ` Michael S. Tsirkin
2021-07-07 19:47 ` David Hildenbrand
2021-07-07 19:57 ` Michael S. Tsirkin
2021-07-08 8:19 ` David Hildenbrand
2021-07-08 19:07 ` Dr. David Alan Gilbert
2021-07-09 11:27 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210707140655.30982-1-david@redhat.com \
--to=david@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).