qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Peter Xu" <peterx@redhat.com>, "Wei Wang" <wei.w.wang@intel.com>,
	"Alexander Duyck" <alexander.duyck@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v2 0/2] virtio-balloon: don't start free page hinting if postcopy is possible
Date: Thu,  8 Jul 2021 11:53:37 +0200	[thread overview]
Message-ID: <20210708095339.20274-1-david@redhat.com> (raw)

This is the follow up on [1]:
  [PATCH v1 0/2] virtio-balloon: disallow postcopy with
  VIRTIO_BALLOON_F_FREE_PAGE_HINT

Working on getting migration for virtio-mem completely right [2] I realized
that virtio-balloon with VIRTIO_BALLOON_F_FREE_PAGE_HINT paired with
postcopy might be shaky. Actually testing it, I directly found two issues,
one of both being far from trivial to fix.

Let's not start free page hinting if postcopy is possible.

v1 -> v2:
- "virtio-balloon: don't start free page hinting if postcopy is possible"
-- Instead of bailing out when starting postcopy, don't start free page
   hinting if the postcopy capability is enabled and we might see the
   switch to postcopy for the current migration (where we might mess with
   the dirty bitmap)
- "virtio-balloon: free page hinting cleanups"
-- Added

[1] https://lkml.kernel.org/r/20210707140655.30982-1-david@redhat.com
[2] https://lkml.kernel.org/r/20210616162940.28630-1-david@redhat.com


David Hildenbrand (2):
  virtio-balloon: don't start free page hinting if postcopy is possible
  virtio-balloon: free page hinting cleanups

 hw/virtio/virtio-balloon.c | 41 +++++++++++++++++++-------------------
 1 file changed, 21 insertions(+), 20 deletions(-)

-- 
2.31.1



             reply	other threads:[~2021-07-08  9:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08  9:53 David Hildenbrand [this message]
2021-07-08  9:53 ` [PATCH v2 1/2] virtio-balloon: don't start free page hinting if postcopy is possible David Hildenbrand
2021-07-08 18:51   ` Peter Xu
2021-07-08  9:53 ` [PATCH v2 2/2] virtio-balloon: free page hinting cleanups David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210708095339.20274-1-david@redhat.com \
    --to=david@redhat.com \
    --cc=alexander.duyck@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).