From: Igor Mammedov <imammedo@redhat.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
mst@redhat.com, Stefan Berger <stefanb@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, marcandre.lureau@redhat.com,
philmd@redhat.com
Subject: Re: [PATCH 3/7] tests: Add suffix tpm2 or tpm12 to ACPI table files
Date: Thu, 8 Jul 2021 17:18:20 +0200 [thread overview]
Message-ID: <20210708171820.3a67ab18@redhat.com> (raw)
In-Reply-To: <7a308683-2642-ff74-3f77-5826c6d5cfbd@linux.ibm.com>
On Thu, 8 Jul 2021 10:17:51 -0400
Stefan Berger <stefanb@linux.ibm.com> wrote:
> On 7/8/21 9:59 AM, Igor Mammedov wrote:
> > On Wed, 30 Jun 2021 11:37:19 -0400
> > Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:
> >
> >> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> >> ---
> >> tests/data/acpi/q35/{DSDT.tis => DSDT.tis.tpm2} | Bin
> >> tests/data/acpi/q35/{TPM2.tis => TPM2.tis.tpm2} | Bin
> >> tests/qtest/bios-tables-test.c | 3 ++-
> >> 3 files changed, 2 insertions(+), 1 deletion(-)
> >> rename tests/data/acpi/q35/{DSDT.tis => DSDT.tis.tpm2} (100%)
> >> rename tests/data/acpi/q35/{TPM2.tis => TPM2.tis.tpm2} (100%)
> > it fails checkpatch which falsely detects it as adding new files
> >
> > ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis.tpm2 and tests/qtest/bios-tables-test.c found
> >
> > ERROR: Do not add expected files together with tests, follow instructions in tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis.tpm2 and tests/qtest/bios-tables-test.c found
> >
> > looks like checkpatch needs to be fixed to handle testcase variant renaming.
>
> Is this a show stopper for upstreaming it?
patch itself looks fine to me but I'm not sure if it's possible CCing Michael/Peter.
next prev parent reply other threads:[~2021-07-08 15:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 15:37 [PATCH 0/7] tests: Add test cases for TPM 1.2 ACPI tables Stefan Berger
2021-06-30 15:37 ` [PATCH 1/7] tests: Rename TestState to TPMTestState Stefan Berger
2021-07-08 14:23 ` Igor Mammedov
2021-06-30 15:37 ` [PATCH 2/7] tests: Add tpm_version field to TPMTestState and fill it Stefan Berger
2021-07-08 14:24 ` Igor Mammedov
2021-06-30 15:37 ` [PATCH 3/7] tests: Add suffix tpm2 or tpm12 to ACPI table files Stefan Berger
2021-07-08 13:59 ` Igor Mammedov
2021-07-08 14:17 ` Stefan Berger
2021-07-08 15:18 ` Igor Mammedov [this message]
2021-07-08 15:27 ` Michael S. Tsirkin
2021-06-30 15:37 ` [PATCH 4/7] test: tpm: Create TPM 1.2 response in TPM emulator Stefan Berger
2021-07-08 15:19 ` Igor Mammedov
2021-06-30 15:37 ` [PATCH 5/7] tests: acpi: prepare for new TPM 1.2 related tables Stefan Berger
2021-07-08 14:25 ` Igor Mammedov
2021-06-30 15:37 ` [PATCH 6/7] tests: acpi: Add test cases for TPM 1.2 with TCPA table Stefan Berger
2021-07-08 14:24 ` Igor Mammedov
2021-06-30 15:37 ` [PATCH 7/7] tests: acpi: tpm1.2: Add expected TPM 1.2 ACPI blobs Stefan Berger
2021-07-08 14:26 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708171820.3a67ab18@redhat.com \
--to=imammedo@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).