From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH 1/4] target/alpha: Store set into rx flag
Date: Thu, 8 Jul 2021 11:25:16 -0700 [thread overview]
Message-ID: <20210708182519.750626-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210708182519.750626-1-richard.henderson@linaro.org>
A paste-o meant that we wrote back the existing value
of the RX flag rather than changing it to TMP.
Use tcg_constant_i64 while we're at it.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/alpha/translate.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index f2922f5f8c..d8bd47de75 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -1116,15 +1116,11 @@ static void gen_msk_l(DisasContext *ctx, TCGv vc, TCGv va, int rb, bool islit,
static void gen_rx(DisasContext *ctx, int ra, int set)
{
- TCGv tmp;
-
if (ra != 31) {
ld_flag_byte(ctx->ir[ra], ENV_FLAG_RX_SHIFT);
}
- tmp = tcg_const_i64(set);
- st_flag_byte(ctx->ir[ra], ENV_FLAG_RX_SHIFT);
- tcg_temp_free(tmp);
+ st_flag_byte(tcg_constant_i64(set), ENV_FLAG_RX_SHIFT);
}
static DisasJumpType gen_call_pal(DisasContext *ctx, int palcode)
--
2.25.1
next prev parent reply other threads:[~2021-07-08 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 18:25 [PATCH 0/4] target/alpha: Use tcg_constant_* Richard Henderson
2021-07-08 18:25 ` Richard Henderson [this message]
2021-07-08 18:25 ` [PATCH 2/4] target/alpha: Use dest_sink for HW_RET temporary Richard Henderson
2021-08-04 21:05 ` Philippe Mathieu-Daudé
2021-07-08 18:25 ` [PATCH 3/4] target/alpha: Use tcg_constant_i64 for zero and lit Richard Henderson
2021-07-08 19:10 ` Philippe Mathieu-Daudé
2021-07-08 18:25 ` [PATCH 4/4] target/alpha: Use tcg_constant_* elsewhere Richard Henderson
2021-07-08 19:10 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210708182519.750626-2-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).