From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 818FDC07E96 for ; Thu, 8 Jul 2021 19:30:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CFD46143F for ; Thu, 8 Jul 2021 19:30:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CFD46143F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1Zj9-0001MG-Bp for qemu-devel@archiver.kernel.org; Thu, 08 Jul 2021 15:30:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1ZSg-0002vQ-Gv for qemu-devel@nongnu.org; Thu, 08 Jul 2021 15:13:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1ZSe-0006Hi-Rv for qemu-devel@nongnu.org; Thu, 08 Jul 2021 15:13:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625771604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P7EAbVHFzBGO+VbO7hTxuI7qNS5vzgab4K/HB8nRRxI=; b=DDWJ0ojMlYItgpkiFYj4NviftsYiXwrpmiFtkMZ0FiO8Cwpn8rxxAZIJ364Wa+a+NPa1dG +d83O+5CRuI1MK3/+FFgSokHq45r0ubVZHaayl4ekZSeedQdGjyJNNiImHQ6vS8YLOZ7ZL 4b6qpgNPyjEuA7arD1cDoCC4bTVWvkc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-gaE2AA-yPbuejNf4Y0n0eQ-1; Thu, 08 Jul 2021 15:13:21 -0400 X-MC-Unique: gaE2AA-yPbuejNf4Y0n0eQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F1615801107 for ; Thu, 8 Jul 2021 19:13:20 +0000 (UTC) Received: from redhat.com (ovpn-112-103.phx2.redhat.com [10.3.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05F125D6A8; Thu, 8 Jul 2021 19:13:16 +0000 (UTC) Date: Thu, 8 Jul 2021 14:13:15 -0500 From: Eric Blake To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH 14/18] crypto: add gnutls cipher provider Message-ID: <20210708191315.esxo4hpmtgdtr2ta@redhat.com> References: <20210706095924.764117-1-berrange@redhat.com> <20210706095924.764117-15-berrange@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210706095924.764117-15-berrange@redhat.com> User-Agent: NeoMutt/20210205-556-f84451-dirty X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , qemu-devel@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 06, 2021 at 10:59:20AM +0100, Daniel P. Berrangé wrote: > Add an implementation of the QEMU cipher APIs to the gnutls > crypto backend. XTS support is only available for gnutls > version >= 3.6.8. Since ECB mode is not exposed by gnutls > APIs, we can't use the private XTS code for compatibility. > > Signed-off-by: Daniel P. Berrangé > --- > crypto/cipher-gnutls.c.inc | 325 +++++++++++++++++++++++++++++++++++++ > crypto/cipher.c | 2 + > 2 files changed, 327 insertions(+) > create mode 100644 crypto/cipher-gnutls.c.inc > > diff --git a/crypto/cipher-gnutls.c.inc b/crypto/cipher-gnutls.c.inc > new file mode 100644 > index 0000000000..eb6eb49546 > --- /dev/null > +++ b/crypto/cipher-gnutls.c.inc > + > +bool qcrypto_cipher_supports(QCryptoCipherAlgorithm alg, > + QCryptoCipherMode mode) > +{ > + > + switch (mode) { > + case QCRYPTO_CIPHER_MODE_ECB: > + case QCRYPTO_CIPHER_MODE_CBC: > + switch (alg) { > + case QCRYPTO_CIPHER_ALG_AES_128: > + case QCRYPTO_CIPHER_ALG_AES_192: > + case QCRYPTO_CIPHER_ALG_AES_256: > + case QCRYPTO_CIPHER_ALG_DES: > + case QCRYPTO_CIPHER_ALG_3DES: > + return true; > + default: > + return false; > + } > +#ifdef QEMU_GNUTLS_XTS > + case QCRYPTO_CIPHER_MODE_XTS: > + switch (alg) { > + case QCRYPTO_CIPHER_ALG_AES_128: > + case QCRYPTO_CIPHER_ALG_AES_256: > + return true; > + default: > + return false; > + } > + return true; This line is dead code. > +#endif > + default: > + return false; > + } > +} > + Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org