* [PATCH] vhost-user: Fix backends without multiqueue support
@ 2021-07-05 17:14 Kevin Wolf
2021-07-07 14:48 ` Cornelia Huck
2021-07-08 21:51 ` Raphael Norwitz
0 siblings, 2 replies; 3+ messages in thread
From: Kevin Wolf @ 2021-07-05 17:14 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, mst, qemu-devel, raphael.norwitz
dev->max_queues was never initialised for backends that don't support
VHOST_USER_PROTOCOL_F_MQ, so it would use 0 as the maximum number of
queues to check against and consequently fail for any such backend.
Set it to 1 if the backend doesn't have multiqueue support.
Fixes: c90bd505a3e8210c23d69fecab9ee6f56ec4a161
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/virtio/vhost-user.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 1ac4a2ebec..29ea2b4fce 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -1913,7 +1913,10 @@ static int vhost_user_backend_init(struct vhost_dev *dev, void *opaque,
if (err < 0) {
return -EPROTO;
}
+ } else {
+ dev->max_queues = 1;
}
+
if (dev->num_queues && dev->max_queues < dev->num_queues) {
error_setg(errp, "The maximum number of queues supported by the "
"backend is %" PRIu64, dev->max_queues);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vhost-user: Fix backends without multiqueue support
2021-07-05 17:14 [PATCH] vhost-user: Fix backends without multiqueue support Kevin Wolf
@ 2021-07-07 14:48 ` Cornelia Huck
2021-07-08 21:51 ` Raphael Norwitz
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2021-07-07 14:48 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: kwolf, raphael.norwitz, qemu-devel, mst
On Mon, Jul 05 2021, Kevin Wolf <kwolf@redhat.com> wrote:
> dev->max_queues was never initialised for backends that don't support
> VHOST_USER_PROTOCOL_F_MQ, so it would use 0 as the maximum number of
> queues to check against and consequently fail for any such backend.
>
> Set it to 1 if the backend doesn't have multiqueue support.
>
> Fixes: c90bd505a3e8210c23d69fecab9ee6f56ec4a161
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> hw/virtio/vhost-user.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost-user: Fix backends without multiqueue support
2021-07-05 17:14 [PATCH] vhost-user: Fix backends without multiqueue support Kevin Wolf
2021-07-07 14:48 ` Cornelia Huck
@ 2021-07-08 21:51 ` Raphael Norwitz
1 sibling, 0 replies; 3+ messages in thread
From: Raphael Norwitz @ 2021-07-08 21:51 UTC (permalink / raw)
To: Kevin Wolf
Cc: mst@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org,
Raphael Norwitz
On Mon, Jul 05, 2021 at 07:14:29PM +0200, Kevin Wolf wrote:
> dev->max_queues was never initialised for backends that don't support
> VHOST_USER_PROTOCOL_F_MQ, so it would use 0 as the maximum number of
> queues to check against and consequently fail for any such backend.
>
> Set it to 1 if the backend doesn't have multiqueue support.
>
> Fixes: c90bd505a3e8210c23d69fecab9ee6f56ec4a161
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
> ---
> hw/virtio/vhost-user.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 1ac4a2ebec..29ea2b4fce 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -1913,7 +1913,10 @@ static int vhost_user_backend_init(struct vhost_dev *dev, void *opaque,
> if (err < 0) {
> return -EPROTO;
> }
> + } else {
> + dev->max_queues = 1;
> }
> +
> if (dev->num_queues && dev->max_queues < dev->num_queues) {
> error_setg(errp, "The maximum number of queues supported by the "
> "backend is %" PRIu64, dev->max_queues);
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-08 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-05 17:14 [PATCH] vhost-user: Fix backends without multiqueue support Kevin Wolf
2021-07-07 14:48 ` Cornelia Huck
2021-07-08 21:51 ` Raphael Norwitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).