From: "Michael S. Tsirkin" <mst@redhat.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: alex.bennee@linaro.org, qemu-devel@nongnu.org,
stratos-dev@op-lists.linaro.org
Subject: Re: [PATCH v2 0/5] virtio: Add vhost-user based RNG
Date: Fri, 9 Jul 2021 03:02:26 -0400 [thread overview]
Message-ID: <20210709025909-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210706202057.GA1540522@p14s>
On Tue, Jul 06, 2021 at 02:20:57PM -0600, Mathieu Poirier wrote:
> Good day Michael,
>
> On Fri, Jul 02, 2021 at 12:27:08PM -0400, Michael S. Tsirkin wrote:
> > On Mon, Jun 14, 2021 at 02:28:37PM -0600, Mathieu Poirier wrote:
> > > This sets adds a vhost-user based random number generator (RNG),
> > > similar to what has been done for i2c and virtiofsd, with the
> > > implementation following the patterns already set forth in those.
> > >
> > > Applies cleanly to git://git.qemu.org/qemu.git master(1ea06abceec6).
> >
> >
> > I get
> >
> > /scm/qemu/docs/tools/vhost-user-rng.rst:document isn't included in any toctree
> >
>
> I assume this is because vhost-user-rng isn't listed in
> docs/tools/index.rst but I would like to test my theory before sending another
> revision. What build command did you use to generate this? I tried "make html"
> and "make man" as shown in the Documenation section of "make help" but those
> targets don't seem to be valid anymore.
>
> Thanks,
> Mathieu
I just used configure then make.
So this is why the patches got dropped from the pull request.
I remember now.
> > any idea?
> >
> > > Thanks,
> > > Mathieu
> > >
> > > -----
> > > New for V2:
> > > - Replaced "antropy" for "entropy" (Joakim).
> > >
> > > Mathieu Poirier (5):
> > > vhost-user-rng: Add vhost-user-rng implementation
> > > vhost-user-rng-pci: Add vhost-user-rng-pci implementation
> > > vhost-user-rng: backend: Add RNG vhost-user daemon implementation
> > > docs: Add documentation for vhost based RNG implementation
> > > MAINTAINERS: Add maintainer for vhost-user RNG implementation
> > >
> > > MAINTAINERS | 9 +
> > > docs/tools/vhost-user-rng.rst | 74 +++++
> > > hw/virtio/Kconfig | 5 +
> > > hw/virtio/meson.build | 2 +
> > > hw/virtio/vhost-user-rng-pci.c | 79 +++++
> > > hw/virtio/vhost-user-rng.c | 294 +++++++++++++++++
> > > include/hw/virtio/vhost-user-rng.h | 33 ++
> > > tools/meson.build | 8 +
> > > tools/vhost-user-rng/50-qemu-rng.json.in | 5 +
> > > tools/vhost-user-rng/main.c | 403 +++++++++++++++++++++++
> > > tools/vhost-user-rng/meson.build | 10 +
> > > 11 files changed, 922 insertions(+)
> > > create mode 100644 docs/tools/vhost-user-rng.rst
> > > create mode 100644 hw/virtio/vhost-user-rng-pci.c
> > > create mode 100644 hw/virtio/vhost-user-rng.c
> > > create mode 100644 include/hw/virtio/vhost-user-rng.h
> > > create mode 100644 tools/vhost-user-rng/50-qemu-rng.json.in
> > > create mode 100644 tools/vhost-user-rng/main.c
> > > create mode 100644 tools/vhost-user-rng/meson.build
> > >
> > > --
> > > 2.25.1
> >
prev parent reply other threads:[~2021-07-09 7:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 20:28 [PATCH v2 0/5] virtio: Add vhost-user based RNG Mathieu Poirier
2021-06-14 20:28 ` [PATCH v2 1/5] vhost-user-rng: Add vhost-user-rng implementation Mathieu Poirier
2021-06-14 20:28 ` [PATCH v2 2/5] vhost-user-rng-pci: Add vhost-user-rng-pci implementation Mathieu Poirier
2021-06-14 20:28 ` [PATCH v2 3/5] vhost-user-rng: backend: Add RNG vhost-user daemon implementation Mathieu Poirier
2021-06-14 20:28 ` [PATCH v2 4/5] docs: Add documentation for vhost based RNG implementation Mathieu Poirier
2021-06-14 20:28 ` [PATCH v2 5/5] MAINTAINERS: Add maintainer for vhost-user " Mathieu Poirier
2021-07-02 16:27 ` [PATCH v2 0/5] virtio: Add vhost-user based RNG Michael S. Tsirkin
2021-07-06 20:20 ` Mathieu Poirier
2021-07-09 7:02 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210709025909-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stratos-dev@op-lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).