From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE700C07E99 for ; Fri, 9 Jul 2021 08:23:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86685613CA for ; Fri, 9 Jul 2021 08:23:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86685613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1lnJ-0000VX-PC for qemu-devel@archiver.kernel.org; Fri, 09 Jul 2021 04:23:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1lmg-0008HJ-FF for qemu-devel@nongnu.org; Fri, 09 Jul 2021 04:22:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1lme-0006eB-Qn for qemu-devel@nongnu.org; Fri, 09 Jul 2021 04:22:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625818972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o8and971sAV3sJCnb5GToOG6cOSMhxkmun04ZY28yZc=; b=XzWMBVYeC0SZ/zmeN/EavjKLMAPXHGz/T0MOCNpBHNzhC6RKRfs0OnaPn/T9rGDbR3L78r FYqG6EXFkVtTpQHdo6Wy+7J66WoBTyZZWeItJSPqNnEdEXzV3GlzWUR9x/pcV6y1AbRE57 ZLq8lLdoKcY6gtqJG02l2BARgnAV7kM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-FMK92W-XP7ik2-WydH9rkw-1; Fri, 09 Jul 2021 04:22:49 -0400 X-MC-Unique: FMK92W-XP7ik2-WydH9rkw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36C0F804141; Fri, 9 Jul 2021 08:22:48 +0000 (UTC) Received: from localhost (unknown [10.43.2.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id 795D819D9F; Fri, 9 Jul 2021 08:22:43 +0000 (UTC) Date: Fri, 9 Jul 2021 10:22:42 +0200 From: Igor Mammedov To: Eduardo Habkost Subject: Re: [PATCH v8 9/9] qtest/hyperv: Introduce a simple hyper-v test Message-ID: <20210709102242.2a7cd7f7@redhat.com> In-Reply-To: <20210708210222.arl4zzquuw75ptwp@habkost.net> References: <20210608120817.1325125-1-vkuznets@redhat.com> <20210608120817.1325125-10-vkuznets@redhat.com> <20210708210222.arl4zzquuw75ptwp@habkost.net> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel@nongnu.org, Paolo Bonzini , Vitaly Kuznetsov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 8 Jul 2021 17:02:22 -0400 Eduardo Habkost wrote: > On Tue, Jun 08, 2021 at 02:08:17PM +0200, Vitaly Kuznetsov wrote: > > For the beginning, just test 'hv-passthrough' and a couple of custom > > Hyper-V enlightenments configurations through QMP. Later, it would > > be great to complement this by checking CPUID values from within the > > guest. > > > > Signed-off-by: Vitaly Kuznetsov > [...] > > +static bool kvm_has_sys_hyperv_cpuid(void) > > +{ > > + int fd = open("/dev/kvm", O_RDWR); > > + int ret; > > + > > + g_assert(fd > 0); > > This crashes when /dev/kvm doesn't exist. See: > https://gitlab.com/ehabkost/qemu/-/jobs/1404084459 maybe reuse qtest_has_accel() https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg06864.html instead of op encoding it. > I'm removing it from the queue. >