From: Igor Mammedov <imammedo@redhat.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: marcandre.lureau@redhat.com,
Stefan Berger <stefanb@linux.ibm.com>,
philmd@redhat.com, qemu-devel@nongnu.org,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 4/9] tests: Add suffix 'tpm2' or 'tpm12' to ACPI table files
Date: Fri, 9 Jul 2021 11:01:59 +0200 [thread overview]
Message-ID: <20210709110159.6b191dd4@redhat.com> (raw)
In-Reply-To: <20210708183814.925960-5-stefanb@linux.vnet.ibm.com>
On Thu, 8 Jul 2021 14:38:09 -0400
Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> tests/qtest/bios-tables-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 93c9d306b5..4ccbe56158 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1101,7 +1101,8 @@ static void test_acpi_tcg_tpm(const char *machine, const char *tpm_if,
> TPMTestState test;
> test_data data;
> GThread *thread;
> - char *args, *variant = g_strdup_printf(".%s", tpm_if);
> + const char *suffix = tpm_version == TPM_VERSION_2_0 ? "tpm2" : "tpm12";
> + char *args, *variant = g_strdup_printf(".%s.%s", tpm_if, suffix);
>
> tpm_tis_base_addr = base;
>
next prev parent reply other threads:[~2021-07-09 9:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 18:38 [PATCH v2 0/9] tests: Add test cases for TPM 1.2 ACPI tables Stefan Berger
2021-07-08 18:38 ` [PATCH v2 1/9] tests: Rename TestState to TPMTestState Stefan Berger
2021-07-08 18:38 ` [PATCH v2 2/9] tests: Add tpm_version field to TPMTestState and fill it Stefan Berger
2021-07-08 18:38 ` [PATCH v2 3/9] tests: acpi: Prepare for renaming of TPM2 related ACPI files Stefan Berger
2021-07-09 9:01 ` Igor Mammedov
2021-07-08 18:38 ` [PATCH v2 4/9] tests: Add suffix 'tpm2' or 'tpm12' to ACPI table files Stefan Berger
2021-07-09 9:01 ` Igor Mammedov [this message]
2021-07-08 18:38 ` [PATCH v2 5/9] tests: acpi: tpm2: Add the renamed ACPI files and drop old ones Stefan Berger
2021-07-09 9:03 ` Igor Mammedov
2021-07-08 18:38 ` [PATCH v2 6/9] tests: tpm: Create TPM 1.2 response in TPM emulator Stefan Berger
2021-07-08 18:38 ` [PATCH v2 7/9] tests: acpi: prepare for new TPM 1.2 related tables Stefan Berger
2021-07-08 18:38 ` [PATCH v2 8/9] tests: acpi: Add test cases for TPM 1.2 with TCPA table Stefan Berger
2021-07-08 18:38 ` [PATCH v2 9/9] tests: acpi: tpm1.2: Add expected TPM 1.2 ACPI blobs Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210709110159.6b191dd4@redhat.com \
--to=imammedo@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).