From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E597C07E99 for ; Fri, 9 Jul 2021 09:29:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4DC96105A for ; Fri, 9 Jul 2021 09:29:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4DC96105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1mp7-0004TG-0m for qemu-devel@archiver.kernel.org; Fri, 09 Jul 2021 05:29:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1mnG-0001il-Mg for qemu-devel@nongnu.org; Fri, 09 Jul 2021 05:27:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1mnF-0004n6-0o for qemu-devel@nongnu.org; Fri, 09 Jul 2021 05:27:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625822851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eV4c+f8AT3tV2jXYFZK+YUgDstXVMg1l7yI7m3XGUTI=; b=EP6fnNsfX0QLmzKtLZ7o7quYy8iWeY2j1osIrkSHWJ7Lmzgx731jphct16/yHgCbLelMW2 XVmyMQlju37PASXV3gjsASUBAsAEL5JAXxBx0TKBbh1poa+qbWEmE9VcggK7SDfCZ/jolU +5OkF6yo+VeueD3ollV6mpe5cLFFGn8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-kHAaaNWwMeWvvMleXfIvjA-1; Fri, 09 Jul 2021 05:27:30 -0400 X-MC-Unique: kHAaaNWwMeWvvMleXfIvjA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 870E6948; Fri, 9 Jul 2021 09:27:29 +0000 (UTC) Received: from localhost (unknown [10.43.2.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C709E706; Fri, 9 Jul 2021 09:27:28 +0000 (UTC) Date: Fri, 9 Jul 2021 11:27:27 +0200 From: Igor Mammedov To: Michal Privoznik Subject: Re: [PATCH 1/2] numa: Report expected initiator Message-ID: <20210709112727.43260241@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tao3.xu@intel.com, qemu-devel@nongnu.org, ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 7 Jul 2021 15:40:29 +0200 Michal Privoznik wrote: > When setting up NUMA with HMAT enabled there's a check performed > in machine_set_cpu_numa_node() that reports an error when a NUMA > node has a CPU but the node's initiator is not itself. The error > message reported contains only the expected value and not the > actual value (which is different because an error is being > reported). Report both values in the error message. > > Signed-off-by: Michal Privoznik Reviewed-by: Igor Mammedov > --- > hw/core/machine.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/core/machine.c b/hw/core/machine.c > index 57c18f909a..6f59fb0b7f 100644 > --- a/hw/core/machine.c > +++ b/hw/core/machine.c > @@ -728,7 +728,8 @@ void machine_set_cpu_numa_node(MachineState *machine, > if ((numa_info[props->node_id].initiator < MAX_NODES) && > (props->node_id != numa_info[props->node_id].initiator)) { > error_setg(errp, "The initiator of CPU NUMA node %" PRId64 > - " should be itself", props->node_id); > + " should be itself (got %" PRIu16 ")", > + props->node_id, numa_info[props->node_id].initiator); > return; > } > numa_info[props->node_id].has_cpu = true;