From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93018C07E99 for ; Fri, 9 Jul 2021 13:24:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19D696115C for ; Fri, 9 Jul 2021 13:24:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19D696115C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1qUU-0002TC-1z for qemu-devel@archiver.kernel.org; Fri, 09 Jul 2021 09:24:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1qNL-0007i5-GY for qemu-devel@nongnu.org; Fri, 09 Jul 2021 09:17:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1qNI-0004X5-Jm for qemu-devel@nongnu.org; Fri, 09 Jul 2021 09:17:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625836617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YsXPVQ3imDlLItadBFrxJrTpHuZzg4WTKjE9FX2tr7I=; b=W6Qd/+ZblToBSwo3Js9hDyjl6KPWZrPGULw0ji9+Jn840H56GwFQ/yJ1OxSysZzRDK7yQ0 zUcyTX8VF9Poy7zcbm0ayTVFWN/EdQ2x5Fx9mY2XBYV8GTNNuBXo//2MowYCLoAbgjgQT+ 56pzO/24xrcXyPzGmiluOB4nxSHSZI0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-570-7_Yye0tGP3KnmyJFQhaBWw-1; Fri, 09 Jul 2021 09:16:54 -0400 X-MC-Unique: 7_Yye0tGP3KnmyJFQhaBWw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 46E19800D62; Fri, 9 Jul 2021 13:16:53 +0000 (UTC) Received: from redhat.com (ovpn-112-103.phx2.redhat.com [10.3.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B19DA60C13; Fri, 9 Jul 2021 13:16:52 +0000 (UTC) Date: Fri, 9 Jul 2021 08:16:50 -0500 From: Eric Blake To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH 1/2] iotests: Improve and rename test 291 to qemu-img-bitmap Message-ID: <20210709131650.atmnvid6376msxpz@redhat.com> References: <20210708013001.2576991-1-eblake@redhat.com> <20210708013001.2576991-2-eblake@redhat.com> <0abfb3e1-7075-39f6-16c9-3690377c2d56@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: <0abfb3e1-7075-39f6-16c9-3690377c2d56@virtuozzo.com> User-Agent: NeoMutt/20210205-556-f84451-dirty X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz , nsoffer@redhat.com, John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 09, 2021 at 09:33:50AM +0300, Vladimir Sementsov-Ogievskiy wrote: > > +++ b/tests/qemu-iotests/tests/qemu-img-bitmaps > > +echo > > +echo "=== Check handling of inconsistent bitmap ===" > > +echo > > + > > +$QEMU_IO -c abort "$TEST_IMG" 2>/dev/null > > +$QEMU_IMG bitmap --add "$TEST_IMG" b4 > > +$QEMU_IMG bitmap --remove "$TEST_IMG" b1 > > +_img_info --format-specific | _filter_irrelevant_img_info > > +$QEMU_IMG convert --bitmaps -O qcow2 "$TEST_IMG" "$TEST_IMG.copy" > > Worth then removing remaining inconsistent bitmaps and try again? > > I think you should now remove $TEST_IMG.copy in _cleanup $TEST_IMG.copy isn't created on failure (or if it is, that in itself is a problem we should be avoiding), so as written, there was nothing that should have needed cleaning up until patch 2. But your idea (here and in patch 2) of demonstrating manual cleanup for recovery (in addition to the goal of patch 2 of skipping broken bitmaps in the first place) is reasonable, so I'll incorporate that into v2. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org