From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, minyihh@uci.edu, berrange@redhat.com,
kuhn.chenqun@huawei.com,
"Richard Henderson" <richard.henderson@linaro.org>,
f4bug@amsat.org, robhenry@microsoft.com,
mahmoudabdalghany@outlook.com, aaron@os.amperecomputing.com,
cota@braap.org, stefanha@redhat.com, crosa@redhat.com,
pbonzini@redhat.com, ma.mandourr@gmail.com,
"Alex Bennée" <alex.bennee@linaro.org>,
aurelien@aurel32.net, "Yonggang Luo" <luoyonggang@gmail.com>
Subject: [PATCH v3 31/40] configure: stop user enabling plugins on Windows for now
Date: Fri, 9 Jul 2021 15:29:56 +0100 [thread overview]
Message-ID: <20210709143005.1554-32-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210709143005.1554-1-alex.bennee@linaro.org>
There are some patches on the list that enable plugins on Windows but
they still need some changes to be ready:
https://patchew.org/QEMU/20201013002806.1447-1-luoyonggang@gmail.com/
In the meantime lets stop the user from being able to configure the
support so they don't get confused by the weird linker error messages
later.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Yonggang Luo <luoyonggang@gmail.com>
---
v2
- move targetos check to if we try to --enable-plugins, default no otherwise
v3
- fix missing test, s/targetos/mingw32/
---
configure | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 25daabd0ff..1eb8ef5341 100755
--- a/configure
+++ b/configure
@@ -708,6 +708,7 @@ MINGW32*)
audio_drv_list=""
fi
supported_os="yes"
+ plugins="no"
pie="no"
;;
GNU/kFreeBSD)
@@ -1511,7 +1512,11 @@ for opt do
;;
--disable-xkbcommon) xkbcommon="disabled"
;;
- --enable-plugins) plugins="yes"
+ --enable-plugins) if test "$mingw32" = "yes"; then
+ error_exit "TCG plugins not currently supported on Windows platforms"
+ else
+ plugins="yes"
+ fi
;;
--disable-plugins) plugins="no"
;;
--
2.20.1
next prev parent reply other threads:[~2021-07-09 14:49 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 14:29 [PATCH for 6.1 v3 00/40] testing and plugins pre-PR Alex Bennée
2021-07-09 14:29 ` [PATCH v3 01/40] Jobs based on custom runners: documentation and configuration placeholder Alex Bennée
2021-07-09 14:29 ` [PATCH v3 02/40] Jobs based on custom runners: build environment docs and playbook Alex Bennée
2021-07-09 14:29 ` [PATCH v3 03/40] Jobs based on custom runners: docs and gitlab-runner setup playbook Alex Bennée
2021-07-09 14:29 ` [PATCH v3 04/40] Jobs based on custom runners: add job definitions for QEMU's machines Alex Bennée
2021-07-09 14:29 ` [PATCH v3 05/40] tests/tcg: also disable the signals test for plugins Alex Bennée
2021-07-09 14:29 ` [PATCH v3 06/40] build: validate that system capstone works before using it Alex Bennée
2021-07-09 14:29 ` [PATCH v3 07/40] gitlab: support for FreeBSD 12, 13 and macOS 11 via cirrus-run Alex Bennée
2021-07-09 14:29 ` [PATCH v3 08/40] cirrus: delete FreeBSD and macOS jobs Alex Bennée
2021-07-09 14:29 ` [PATCH v3 09/40] hw/usb/ccid: remove references to NSS Alex Bennée
2021-07-09 14:29 ` [PATCH v3 10/40] tests/docker: don't use BUILDKIT in GitLab either Alex Bennée
2021-07-09 14:29 ` [PATCH v3 11/40] tests/docker: use project specific container registries Alex Bennée
2021-07-09 14:29 ` [PATCH v3 12/40] tests/docker: use explicit docker.io registry Alex Bennée
2021-07-09 14:29 ` [PATCH v3 13/40] tests/docker: remove FEATURES env var from templates Alex Bennée
2021-07-09 14:29 ` [PATCH v3 14/40] tests/docker: fix sorting in package lists Alex Bennée
2021-07-09 14:29 ` [PATCH v3 15/40] tests/docker: fix mistakes in centos " Alex Bennée
2021-07-09 14:29 ` [PATCH v3 16/40] tests/docker: fix mistakes in fedora package list Alex Bennée
2021-07-09 14:29 ` [PATCH v3 17/40] tests/docker: fix mistakes in ubuntu package lists Alex Bennée
2021-07-09 14:29 ` [PATCH v3 18/40] tests/docker: remove mingw packages from Fedora Alex Bennée
2021-07-09 14:29 ` [PATCH v3 19/40] tests/docker: expand centos8 package list Alex Bennée
2021-07-09 14:29 ` [PATCH v3 20/40] tests/docker: expand fedora " Alex Bennée
2021-07-09 14:29 ` [PATCH v3 21/40] tests/docker: expand ubuntu1804 " Alex Bennée
2021-07-09 14:29 ` [PATCH v3 22/40] tests/docker: expand ubuntu2004 " Alex Bennée
2021-07-09 14:29 ` [PATCH v3 23/40] tests/docker: expand opensuse-leap " Alex Bennée
2021-07-09 14:29 ` [PATCH v3 24/40] tests/vm: update NetBSD to 9.2 Alex Bennée
2021-07-09 14:29 ` [PATCH v3 25/40] tests/vm: update openbsd to release 6.9 Alex Bennée
2021-07-09 14:29 ` [PATCH v3 26/40] tests/tcg: make test-mmap a little less aggressive Alex Bennée
2021-07-09 15:04 ` Richard Henderson
2021-07-11 23:59 ` Taylor Simpson
2021-07-09 14:29 ` [PATCH v3 27/40] plugins: fix-up handling of internal hostaddr for 32 bit Alex Bennée
2021-07-09 14:29 ` [PATCH v3 28/40] meson.build: move TCG plugin summary output Alex Bennée
2021-07-09 14:29 ` [PATCH v3 29/40] configure: don't allow plugins to be enabled for a non-TCG build Alex Bennée
2021-07-09 14:29 ` [PATCH v3 30/40] configure: add an explicit static and plugins check Alex Bennée
2021-07-09 15:06 ` Richard Henderson
2021-07-09 14:29 ` Alex Bennée [this message]
2021-07-09 14:29 ` [PATCH v3 32/40] tcg/plugins: enable by default for most TCG builds Alex Bennée
2021-07-09 15:12 ` Richard Henderson
2021-07-09 14:29 ` [PATCH v3 33/40] contrib/plugins: enable -Wall for building plugins Alex Bennée
2021-07-09 14:29 ` [PATCH v3 34/40] contrib/plugins: add execlog to log instruction execution and memory access Alex Bennée
2021-07-09 14:30 ` [PATCH v3 35/40] docs/devel: tcg-plugins: add execlog plugin description Alex Bennée
2021-07-09 14:30 ` [PATCH v3 36/40] plugins: Added a new cache modelling plugin Alex Bennée
2021-07-09 14:30 ` [PATCH v3 37/40] plugins/cache: Enable cache parameterization Alex Bennée
2021-07-09 14:30 ` [PATCH v3 38/40] plugins/cache: Added FIFO and LRU eviction policies Alex Bennée
2021-07-09 14:30 ` [PATCH v3 39/40] docs/devel: Added cache plugin to the plugins docs Alex Bennée
2021-07-09 14:30 ` [PATCH v3 40/40] MAINTAINERS: Added myself as a reviewer for TCG Plugins Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210709143005.1554-32-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aaron@os.amperecomputing.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=kuhn.chenqun@huawei.com \
--cc=luoyonggang@gmail.com \
--cc=ma.mandourr@gmail.com \
--cc=mahmoudabdalghany@outlook.com \
--cc=minyihh@uci.edu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robhenry@microsoft.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).