From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D69C07E99 for ; Fri, 9 Jul 2021 14:49:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A01CF61363 for ; Fri, 9 Jul 2021 14:49:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A01CF61363 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1rpD-0000VL-Pg for qemu-devel@archiver.kernel.org; Fri, 09 Jul 2021 10:49:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1rdV-0004yr-DN for qemu-devel@nongnu.org; Fri, 09 Jul 2021 10:37:49 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:45640) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1rdP-0000GQ-CE for qemu-devel@nongnu.org; Fri, 09 Jul 2021 10:37:49 -0400 Received: by mail-wm1-x32b.google.com with SMTP id u8-20020a7bcb080000b02901e44e9caa2aso6441598wmj.4 for ; Fri, 09 Jul 2021 07:37:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=77kFc+Y+5Qbz2V5mv8qtdgKvR0JhiM/gX4TZj6U9Mb0=; b=QFaPXiKW7BbgiZTB2aq6DW7FLPG1lGSp1H1KG1n5a/zNWzXG/a5lWWVcVjtNtSeptS P2BnF5ilB962LKiO9dBpAbVOCPJQm1TEYQ1YZfyqsE1mrnwHk1qlJ63SFvBuLu5IOq17 ZnIfrp9wIs1AHcJYUoKUMsaHHAtFtxQcPht12KWjv/6rpaqQlUDO+MT6dQnIfLxxfji1 Y07u+Wx5xgfGqjapOPJ4qCiV/t36Xtr37JR63kqMC7NHNwQOrDuJmyFCfCuoGP/G2Zo7 95wTA/+NP5wHtzorbcSaLNIgkzkWBfIQuTPDHuRpGYMFHn3sEM4Qtg5xWvlGZZS97xcf I9iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=77kFc+Y+5Qbz2V5mv8qtdgKvR0JhiM/gX4TZj6U9Mb0=; b=DpPsyzLj7I0v6tJ2X/kUwaOfjMWGcgEXNl6jKqGsC76OSvJNxFQgv92lq5eMX9vkft JyVnZe3wfZc9ddablnb2aC42lss90eyUyZpnzYf767nUlzRibR15y5pH9Z9Z6HSsaY30 1grlDV7+PwY7zT59MLlGHYXfWMv83ZNo2wVAeHRTIeqdBTkPjok5kwg9T7+0Jr6SUTm3 hF4iD8120hpYtC8031nivn1A4PDlIYDRtFGplb3We8vSdLlaGJ49cN7YsS2nz4ln1+6I +nUdcYaTwduXI8JURJdMGl/yfzs8c8HaKe3dGs1NZX1TDbEOzjLuj2QRu9EGVjdvMej2 TKjg== X-Gm-Message-State: AOAM532pcROIzdmMCZQTX9wk6ec/yy5unS9stIQAQ4Dqay2a/fa02ZE3 z9m/86AP2NhGNP5YyJgxC9HAEw== X-Google-Smtp-Source: ABdhPJx2nedH0TyMSwcKZvijUkHnDEdYHLCDfZTLj8/ao6g3yyndWNU4e1QOppqD3vTZFO2e7LjrZw== X-Received: by 2002:a05:600c:4f4e:: with SMTP id m14mr12450822wmq.151.1625841461654; Fri, 09 Jul 2021 07:37:41 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id c2sm1427408wrn.28.2021.07.09.07.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 07:37:31 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id F1D601FFB4; Fri, 9 Jul 2021 15:30:12 +0100 (BST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v3 31/40] configure: stop user enabling plugins on Windows for now Date: Fri, 9 Jul 2021 15:29:56 +0100 Message-Id: <20210709143005.1554-32-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210709143005.1554-1-alex.bennee@linaro.org> References: <20210709143005.1554-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, minyihh@uci.edu, berrange@redhat.com, kuhn.chenqun@huawei.com, Richard Henderson , f4bug@amsat.org, robhenry@microsoft.com, mahmoudabdalghany@outlook.com, aaron@os.amperecomputing.com, cota@braap.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, ma.mandourr@gmail.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , aurelien@aurel32.net, Yonggang Luo Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" There are some patches on the list that enable plugins on Windows but they still need some changes to be ready: https://patchew.org/QEMU/20201013002806.1447-1-luoyonggang@gmail.com/ In the meantime lets stop the user from being able to configure the support so they don't get confused by the weird linker error messages later. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Cc: Yonggang Luo --- v2 - move targetos check to if we try to --enable-plugins, default no otherwise v3 - fix missing test, s/targetos/mingw32/ --- configure | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 25daabd0ff..1eb8ef5341 100755 --- a/configure +++ b/configure @@ -708,6 +708,7 @@ MINGW32*) audio_drv_list="" fi supported_os="yes" + plugins="no" pie="no" ;; GNU/kFreeBSD) @@ -1511,7 +1512,11 @@ for opt do ;; --disable-xkbcommon) xkbcommon="disabled" ;; - --enable-plugins) plugins="yes" + --enable-plugins) if test "$mingw32" = "yes"; then + error_exit "TCG plugins not currently supported on Windows platforms" + else + plugins="yes" + fi ;; --disable-plugins) plugins="no" ;; -- 2.20.1