qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH 37/41] accel/tcg: Move tb_lookup to cpu-exec.c
Date: Sat, 10 Jul 2021 08:31:39 -0700	[thread overview]
Message-ID: <20210710153143.1320521-38-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210710153143.1320521-1-richard.henderson@linaro.org>

Now that we've moved helper_lookup_tb_ptr, the only user
of tb-lookup.h is cpu-exec.c; merge the contents in.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 accel/tcg/tb-lookup.h | 49 -------------------------------------------
 accel/tcg/cpu-exec.c  | 31 ++++++++++++++++++++++++++-
 2 files changed, 30 insertions(+), 50 deletions(-)
 delete mode 100644 accel/tcg/tb-lookup.h

diff --git a/accel/tcg/tb-lookup.h b/accel/tcg/tb-lookup.h
deleted file mode 100644
index 9c9e0079da..0000000000
--- a/accel/tcg/tb-lookup.h
+++ /dev/null
@@ -1,49 +0,0 @@
-/*
- * Copyright (C) 2017, Emilio G. Cota <cota@braap.org>
- *
- * License: GNU GPL, version 2 or later.
- *   See the COPYING file in the top-level directory.
- */
-#ifndef EXEC_TB_LOOKUP_H
-#define EXEC_TB_LOOKUP_H
-
-#ifdef NEED_CPU_H
-#include "cpu.h"
-#else
-#include "exec/poison.h"
-#endif
-
-#include "exec/exec-all.h"
-#include "tb-hash.h"
-
-/* Might cause an exception, so have a longjmp destination ready */
-static inline TranslationBlock *tb_lookup(CPUState *cpu, target_ulong pc,
-                                          target_ulong cs_base,
-                                          uint32_t flags, uint32_t cflags)
-{
-    TranslationBlock *tb;
-    uint32_t hash;
-
-    /* we should never be trying to look up an INVALID tb */
-    tcg_debug_assert(!(cflags & CF_INVALID));
-
-    hash = tb_jmp_cache_hash_func(pc);
-    tb = qatomic_rcu_read(&cpu->tb_jmp_cache[hash]);
-
-    if (likely(tb &&
-               tb->pc == pc &&
-               tb->cs_base == cs_base &&
-               tb->flags == flags &&
-               tb->trace_vcpu_dstate == *cpu->trace_dstate &&
-               tb_cflags(tb) == cflags)) {
-        return tb;
-    }
-    tb = tb_htable_lookup(cpu, pc, cs_base, flags, cflags);
-    if (tb == NULL) {
-        return NULL;
-    }
-    qatomic_set(&cpu->tb_jmp_cache[hash], tb);
-    return tb;
-}
-
-#endif /* EXEC_TB_LOOKUP_H */
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index fb6668606f..0d92698030 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -40,7 +40,6 @@
 #include "sysemu/replay.h"
 #include "exec/helper-proto.h"
 #include "tb-hash.h"
-#include "tb-lookup.h"
 #include "tb-context.h"
 #include "internal.h"
 
@@ -146,6 +145,36 @@ static void init_delay_params(SyncClocks *sc, const CPUState *cpu)
 }
 #endif /* CONFIG USER ONLY */
 
+/* Might cause an exception, so have a longjmp destination ready */
+static inline TranslationBlock *tb_lookup(CPUState *cpu, target_ulong pc,
+                                          target_ulong cs_base,
+                                          uint32_t flags, uint32_t cflags)
+{
+    TranslationBlock *tb;
+    uint32_t hash;
+
+    /* we should never be trying to look up an INVALID tb */
+    tcg_debug_assert(!(cflags & CF_INVALID));
+
+    hash = tb_jmp_cache_hash_func(pc);
+    tb = qatomic_rcu_read(&cpu->tb_jmp_cache[hash]);
+
+    if (likely(tb &&
+               tb->pc == pc &&
+               tb->cs_base == cs_base &&
+               tb->flags == flags &&
+               tb->trace_vcpu_dstate == *cpu->trace_dstate &&
+               tb_cflags(tb) == cflags)) {
+        return tb;
+    }
+    tb = tb_htable_lookup(cpu, pc, cs_base, flags, cflags);
+    if (tb == NULL) {
+        return NULL;
+    }
+    qatomic_set(&cpu->tb_jmp_cache[hash], tb);
+    return tb;
+}
+
 /**
  * helper_lookup_tb_ptr: quick check for next tb
  * @env: current cpu state
-- 
2.25.1



  parent reply	other threads:[~2021-07-10 15:57 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 15:31 [PATCH 00/41] tcg patch queue Richard Henderson
2021-07-10 15:31 ` [PATCH 01/41] tcg: Add separator in INDEX_op_call dump Richard Henderson
2021-07-10 15:31 ` [PATCH 02/41] tcg: Avoid including 'trace-tcg.h' in target translate.c Richard Henderson
2021-07-10 15:31 ` [PATCH 03/41] accel/tcg: Hoist tcg_tb_insert() up above tb_link_page() Richard Henderson
2021-07-10 15:31 ` [PATCH 04/41] tcg: Bake tb_destroy() into tcg_region_tree Richard Henderson
2021-07-10 15:31 ` [PATCH 05/41] tcg: Move tb_phys_invalidate_count to tb_ctx Richard Henderson
2021-07-10 15:31 ` [PATCH 06/41] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
2021-07-10 15:31 ` [PATCH 07/41] target/alpha: Remove use_exit_tb Richard Henderson
2021-07-10 15:31 ` [PATCH 08/41] target/alpha: Remove in_superpage Richard Henderson
2021-07-10 15:31 ` [PATCH 09/41] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-07-10 15:31 ` [PATCH 10/41] target/arm: Use DISAS_TOO_MANY for ISB and SB Richard Henderson
2021-07-10 15:31 ` [PATCH 11/41] target/arm: Use translator_use_goto_tb for aarch64 Richard Henderson
2021-07-10 15:31 ` [PATCH 12/41] target/arm: Use translator_use_goto_tb for aarch32 Richard Henderson
2021-07-10 15:31 ` [PATCH 13/41] target/avr: Use translator_use_goto_tb Richard Henderson
2021-07-10 15:31 ` [PATCH 14/41] target/avr: Mark some helpers noreturn Richard Henderson
2021-07-10 15:31 ` [PATCH 15/41] target/cris: Use translator_use_goto_tb Richard Henderson
2021-07-10 15:31 ` [PATCH 16/41] target/hppa: " Richard Henderson
2021-07-10 15:31 ` [PATCH 17/41] target/i386: " Richard Henderson
2021-07-10 15:31 ` [PATCH 18/41] target/m68k: " Richard Henderson
2021-07-10 15:31 ` [PATCH 19/41] target/microblaze: " Richard Henderson
2021-07-10 15:31 ` [PATCH 20/41] target/mips: " Richard Henderson
2021-07-10 15:31 ` [PATCH 21/41] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-07-10 15:31 ` [PATCH 22/41] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-07-10 15:31 ` [PATCH 23/41] target/openrisc: " Richard Henderson
2021-07-10 15:31 ` [PATCH 24/41] target/ppc: " Richard Henderson
2021-07-10 15:31 ` [PATCH 25/41] target/riscv: " Richard Henderson
2021-07-10 15:31 ` [PATCH 26/41] target/rx: " Richard Henderson
2021-07-10 15:31 ` [PATCH 27/41] target/s390x: " Richard Henderson
2021-07-10 15:31 ` [PATCH 28/41] target/s390x: Remove use_exit_tb Richard Henderson
2021-07-10 15:31 ` [PATCH 29/41] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-07-10 15:31 ` [PATCH 30/41] target/sparc: " Richard Henderson
2021-07-10 15:31 ` [PATCH 31/41] target/tricore: " Richard Henderson
2021-07-10 15:31 ` [PATCH 32/41] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-07-10 15:31 ` [PATCH 33/41] target/xtensa: Use translator_use_goto_tb Richard Henderson
2021-07-10 15:31 ` [PATCH 34/41] tcg: Fix prologue disassembly Richard Henderson
2021-07-10 15:31 ` [PATCH 35/41] target/i386: Use cpu_breakpoint_test in breakpoint_handler Richard Henderson
2021-07-10 15:31 ` [PATCH 36/41] accel/tcg: Move helper_lookup_tb_ptr to cpu-exec.c Richard Henderson
2021-07-10 15:31 ` Richard Henderson [this message]
2021-07-10 15:31 ` [PATCH 38/41] accel/tcg: Split out log_cpu_exec Richard Henderson
2021-07-10 15:31 ` [PATCH 39/41] accel/tcg: Log tb->cflags with -d exec Richard Henderson
2021-07-10 15:31 ` [PATCH 40/41] tcg: Remove TCG_TARGET_HAS_goto_ptr Richard Henderson
2021-07-10 15:31 ` [PATCH 41/41] cpu: Add breakpoint tracepoints Richard Henderson
2021-07-10 16:24 ` [PATCH 00/41] tcg patch queue Peter Maydell
2021-07-11  0:12   ` Richard Henderson
2021-07-12 11:53 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210710153143.1320521-38-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).