From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B687FC07E96 for ; Sun, 11 Jul 2021 10:39:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77352611CC for ; Sun, 11 Jul 2021 10:39:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77352611CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2Wrn-0003FK-Mj for qemu-devel@archiver.kernel.org; Sun, 11 Jul 2021 06:39:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2Wow-0006DI-TS for qemu-devel@nongnu.org; Sun, 11 Jul 2021 06:36:22 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:38691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2Wov-00043i-IF for qemu-devel@nongnu.org; Sun, 11 Jul 2021 06:36:22 -0400 Received: by mail-wr1-x433.google.com with SMTP id g16so10175201wrw.5 for ; Sun, 11 Jul 2021 03:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mTZV+n/oh33t5seqMlDVWHULoEHrUF2lMDudl7/Bh6s=; b=bA0pK6Bf+Y3nBimW4sJ28eCDZm5DWog5sFVgr4LKRSNLkBOs0OLEdo2K5rmer2l7B8 Q301sZ6NAAK6I/tKKh4GkjagC59u/dnY7yHI2G3arsgZuICzbMN64i0mlorF5xQN0zYu W+bwG5SN7i3G+Kw+QTLVPzJLwizq5CQIfsPKkZRD1wVmmy3NtaHsH2205edbborJ6nFy js4xgmqZaOxEKqw6aAGDQTYvDooQOQcckdrF93HiqScStfqpeWNU05ZUZTF3N19gig92 gq2L3rsC0R0gwkRtgHbcQ37LMwfbExZtSM2W0EZejozpVGu64PGBaVubZVtBfe1wmwNp VlOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=mTZV+n/oh33t5seqMlDVWHULoEHrUF2lMDudl7/Bh6s=; b=t+Cguknw70Yuq+eiH3/15q6zmEGepMsbtRaiBiaOUbqHr4oO9iizChwCMYbG+11CIp hWEOiUQW8qGfvOYM4Yuiqd7iLrwYmu5qfCC0Ttt9BTYwaY6+7+VyI4V3Scmyd5YXIdDl 8AnbaoeL+r9T8GirwJ6pRueCHBIjJemOsZzKUCrjD7L6QunfCWdFCZuLPyIts3uhwb0U Gq1l2UwBz2ZxSl7s1NbLGeiB8150H2xNcoyLsGEB9GEHIb22eP2OZrP/zmUXFiBYsbAR wnR8k05VjwgNbkRImKLnP40z1fiQrFGpwyWAA/b0UfPSvgExbLq3yBc8uFfyggOt/i0w 6ELA== X-Gm-Message-State: AOAM530lJVwRbWqhoCwcJB51bnSNcznOBQOtA+VhXpxLUiUOl6DmeWV2 4JS6xqQZ/wWxA6397H1xXF91psa76vZDnA== X-Google-Smtp-Source: ABdhPJyPfz0EbqyyVcD2WyIpJdL4gi52TxHGQXdgohCh98ZHVCNyxIspaWll1VI27Bjj/Nv/pfQA/Q== X-Received: by 2002:a5d:4449:: with SMTP id x9mr27022000wrr.52.1625999780052; Sun, 11 Jul 2021 03:36:20 -0700 (PDT) Received: from x1w.. (static-189-95-145-212.ipcom.comunitel.net. [212.145.95.189]) by smtp.gmail.com with ESMTPSA id j17sm20194210wmq.9.2021.07.11.03.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jul 2021 03:36:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v4 1/5] dp8393x: Replace address_space_rw(is_write=1) by address_space_write() Date: Sun, 11 Jul 2021 12:36:08 +0200 Message-Id: <20210711103612.2661521-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210711103612.2661521-1-f4bug@amsat.org> References: <20210711103612.2661521-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Finn Thain , Jason Wang , Mark Cave-Ayland , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Herv=C3=A9=20Poussineau?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Replace address_space_rw(is_write=1) by address_space_write() and remove pointless cast. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Tested-by: Finn Thain Message-Id: <20210710174954.2577195-2-f4bug@amsat.org> --- hw/net/dp8393x.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 11810c9b600..9118364aa33 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -816,8 +816,8 @@ static ssize_t dp8393x_receive(NetClientState *nc, const uint8_t * buf, size = sizeof(uint16_t) * width; address = dp8393x_crda(s) + sizeof(uint16_t) * 6 * width; dp8393x_put(s, width, 0, 0); - address_space_rw(&s->as, address, MEMTXATTRS_UNSPECIFIED, - (uint8_t *)s->data, size, 1); + address_space_write(&s->as, address, MEMTXATTRS_UNSPECIFIED, + s->data, size); /* Move to next descriptor */ s->regs[SONIC_CRDA] = s->regs[SONIC_LLFA]; @@ -846,8 +846,8 @@ static ssize_t dp8393x_receive(NetClientState *nc, const uint8_t * buf, /* Pad short packets to keep pointers aligned */ if (rx_len < padded_len) { size = padded_len - rx_len; - address_space_rw(&s->as, address, MEMTXATTRS_UNSPECIFIED, - (uint8_t *)"\xFF\xFF\xFF", size, 1); + address_space_write(&s->as, address, MEMTXATTRS_UNSPECIFIED, + "\xFF\xFF\xFF", size); address += size; } -- 2.31.1