From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, pbonzini@redhat.com, crobinso@redhat.com
Subject: [PATCH 0/3] Atomic cleanup + clang-12 build fix
Date: Mon, 12 Jul 2021 08:59:15 -0700 [thread overview]
Message-ID: <20210712155918.1422519-1-richard.henderson@linaro.org> (raw)
The first two patches are not strictly required, but they
were useful in tracking down the root problem here.
I understand the logic behind the clang-12 warning, but I think
it's a clear mistake that it should be enabled by default for a
target where alignment is not enforced by default.
I found over a dozen places where we would have to manually add
QEMU_ALIGNED(8) to uint64_t declarations in order to suppress
all of the instances. IMO there's no point fighting this.
r~
Richard Henderson (3):
qemu/atomic: Remove pre-C11 atomic fallbacks
qemu/atomic: Use macros for CONFIG_ATOMIC64
configure: Conditionally disable clang-12 -Watomic-alignment
configure | 23 +++--
include/qemu/atomic.h | 229 +++---------------------------------------
2 files changed, 31 insertions(+), 221 deletions(-)
--
2.25.1
next reply other threads:[~2021-07-12 16:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 15:59 Richard Henderson [this message]
2021-07-12 15:59 ` [PATCH 1/3] qemu/atomic: Remove pre-C11 atomic fallbacks Richard Henderson
2021-07-12 15:59 ` [PATCH 2/3] qemu/atomic: Use macros for CONFIG_ATOMIC64 Richard Henderson
2021-07-12 16:29 ` Philippe Mathieu-Daudé
2021-07-12 15:59 ` [PATCH 3/3] configure: Conditionally disable clang-12 -Watomic-alignment Richard Henderson
2021-07-12 21:30 ` [PATCH 0/3] Atomic cleanup + clang-12 build fix Cole Robinson
2021-07-13 0:37 ` Richard Henderson
2021-07-13 14:43 ` Richard Henderson
2021-07-13 15:18 ` Cole Robinson
2021-07-13 16:56 ` Richard Henderson
2021-07-15 15:11 ` Cole Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712155918.1422519-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=crobinso@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).