From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PULL 5/6] trace/simple: add st_init_group
Date: Mon, 12 Jul 2021 17:50:00 +0100 [thread overview]
Message-ID: <20210712165001.429113-6-stefanha@redhat.com> (raw)
In-Reply-To: <20210712165001.429113-1-stefanha@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Add helper function and call it for each trace event group added.
Makes sure that events added at module load time are initialized
properly.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20210601132414.432430-6-kraxel@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
trace/simple.h | 1 +
trace/control.c | 4 ++++
trace/simple.c | 12 ++++++++++++
3 files changed, 17 insertions(+)
diff --git a/trace/simple.h b/trace/simple.h
index 26ccbc8b8a..ee1983ce56 100644
--- a/trace/simple.h
+++ b/trace/simple.h
@@ -15,6 +15,7 @@ void st_print_trace_file_status(void);
bool st_set_trace_file_enabled(bool enable);
void st_set_trace_file(const char *file);
bool st_init(void);
+void st_init_group(size_t group);
void st_flush_trace_buffer(void);
typedef struct {
diff --git a/trace/control.c b/trace/control.c
index 2c904b7ee4..d5b68e846e 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -82,6 +82,10 @@ void trace_event_register_group(TraceEvent **events)
event_groups = g_renew(TraceEventGroup, event_groups, nevent_groups + 1);
event_groups[nevent_groups].events = events;
nevent_groups++;
+
+#ifdef CONFIG_TRACE_SIMPLE
+ st_init_group(nevent_groups - 1);
+#endif
}
diff --git a/trace/simple.c b/trace/simple.c
index ec2156d135..ac499edee0 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -422,3 +422,15 @@ bool st_init(void)
atexit(st_flush_trace_buffer);
return true;
}
+
+void st_init_group(size_t group)
+{
+ TraceEventIter iter;
+
+ if (!trace_writeout_enabled) {
+ return;
+ }
+
+ trace_event_iter_init_group(&iter, group);
+ st_write_event_mapping(&iter);
+}
--
2.31.1
next prev parent reply other threads:[~2021-07-12 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 16:49 [PULL 0/6] Tracing patches Stefan Hajnoczi
2021-07-12 16:49 ` [PULL 1/6] qemu-trace-stap: changing SYSTEMTAP_TAPSET considered harmful Stefan Hajnoczi
2021-07-12 16:49 ` [PULL 2/6] trace: iter init tweaks Stefan Hajnoczi
2021-07-12 16:49 ` [PULL 3/6] trace: add trace_event_iter_init_group Stefan Hajnoczi
2021-07-12 16:49 ` [PULL 4/6] trace/simple: pass iter to st_write_event_mapping Stefan Hajnoczi
2021-07-12 16:50 ` Stefan Hajnoczi [this message]
2021-07-12 16:50 ` [PULL 6/6] trace, lttng: require .pc files Stefan Hajnoczi
2021-07-13 13:31 ` [PULL 0/6] Tracing patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712165001.429113-6-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).