From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23C7C07E99 for ; Mon, 12 Jul 2021 17:12:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D638611CD for ; Mon, 12 Jul 2021 17:12:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D638611CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2zTx-0000vk-NZ for qemu-devel@archiver.kernel.org; Mon, 12 Jul 2021 13:12:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2zRV-00061c-SQ for qemu-devel@nongnu.org; Mon, 12 Jul 2021 13:10:06 -0400 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]:41810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2zRU-0007O2-0u for qemu-devel@nongnu.org; Mon, 12 Jul 2021 13:10:05 -0400 Received: by mail-ej1-x630.google.com with SMTP id go30so8906902ejc.8 for ; Mon, 12 Jul 2021 10:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UtPtNn8ftw/KiXb4mpy41KrE1wYrg158kWzmq14tXRs=; b=GR2abcL7WvvLb2/yfTJTSfciDopoBvUAaZOSSxW38qPtFeedJF1sPc/IDMnBaUiCxJ SPhP7QjfQFxdaeC3ZvHeaic2SLBhYoeKxfmT4rh0kUXCSsshsIiqdsMwhiPRQ9+kKRQJ /THvHYhXtWUbY7154Bdio0n10c3C4+o9FVmjgLIX/9vKq9XB4YywcZGxKNFxt41Vxyrt QIiL/4y8hCOsfbSt3nFiOa8BeALozv6H9tEHHGTc+rhqsLW1WGrMaaML/T0b0TawO6ZP yJpWHeyxRrBZMJXkDWg7eZ6VM/zqDDXiGSYqKgTPfZEXe0LVxN89b2NcfufJHbaKm9z8 gI5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=UtPtNn8ftw/KiXb4mpy41KrE1wYrg158kWzmq14tXRs=; b=RbPbPCCdjudmvlmfHXruF5VU9A8O1ZY8zma9lCA9+zew9wyX/hiNGlr/ur63wvLaA8 GHOi69em6VCyreAiQInior6UDS8NezNQTTSqNfHyTS5BA80eeMbn6tzHC2Ke/1Z9JdZp jkvtVFkYM4osbFcoM6SAltJU4d9xvw4Pc0GKJYH2aKkuZHsPX3TxbFOGUxAtmdP5GAyA AyyNYeir5DkHuSyQafFufdMEMHMnddyyb6x5VU1oJ3Qe1Keyf6uLU7BedGruLu9EIxJg Dvh4v8SR3yoDKFScdKvGhQFhfH1LeZtubK3Oqe/a3hvmK7SFEXzbAmLJAFt6Sz54HnFN eJMw== X-Gm-Message-State: AOAM530axtDEUxlW8jFxP2XVcjn9mHZAAof6ocjl0AWCsW8zSNVAwWaV +17g2HHSBT4+dmdqXhNnk+3BgXvac7Q= X-Google-Smtp-Source: ABdhPJyVNKLfI7ubOzJIhpdP3UjHAWeDG9bT/S10/4Qzsxdm95dW5BT6dRdeYYPx2ujJg9hflCwxJQ== X-Received: by 2002:a17:906:5650:: with SMTP id v16mr66387ejr.533.1626109802319; Mon, 12 Jul 2021 10:10:02 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id t4sm2969776ejo.125.2021.07.12.10.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 10:10:01 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH v2] disable modular TCG on Darwin Date: Mon, 12 Jul 2021 19:09:53 +0200 Message-Id: <20210712170953.554555-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=paolo.bonzini@gmail.com; helo=mail-ej1-x630.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Accelerator modularity does not work on Darwin: ld: illegal thread local variable reference to regular symbol _current_cpu for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Fix by avoiding modular TCG builds. Signed-off-by: Paolo Bonzini --- meson.build | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index dd7f9ed6a8..6bfc44f7d7 100644 --- a/meson.build +++ b/meson.build @@ -92,7 +92,11 @@ if cpu in ['x86', 'x86_64'] } endif -modular_tcg = ['i386-softmmu', 'x86_64-softmmu'] +modular_tcg = [] +# Darwin does not support references to thread-local variables in modules +if targetos != 'darwin' + modular_tcg = ['i386-softmmu', 'x86_64-softmmu'] +endif edk2_targets = [ 'arm-softmmu', 'aarch64-softmmu', 'i386-softmmu', 'x86_64-softmmu' ] install_edk2_blobs = false -- 2.31.1