From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org, groug@kaod.org
Cc: aik@ozlabs.ru, David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: [PULL 3/3] mv64361: Remove extra break from a switch case
Date: Tue, 13 Jul 2021 12:07:36 +1000 [thread overview]
Message-ID: <20210713020736.28960-4-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20210713020736.28960-1-david@gibson.dropbear.id.au>
From: BALATON Zoltan <balaton@eik.bme.hu>
The switch case of writing PCI 1 IO base address had an extra break
statement that made part of the code unreachable. This did not cause a
problem as guests ususally leave this register at its default value.
Fixes: dcdf98a9015 ("Add emulation of Marvell MV64361 PPC system
controller")
Reported-by: Coverity (CID 1458135)
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: <20210712131259.B705B7456E3@zero.eik.bme.hu>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/pci-host/mv64361.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/pci-host/mv64361.c b/hw/pci-host/mv64361.c
index 20510d8680..92b0f5d047 100644
--- a/hw/pci-host/mv64361.c
+++ b/hw/pci-host/mv64361.c
@@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr, uint64_t val,
case MV64340_PCI_1_IO_BASE_ADDR:
s->pci[1].io_base = val & 0x30fffffULL;
warn_swap_bit(val);
- break;
if (!(s->cpu_conf & BIT(27))) {
s->pci[1].remap[4] = (val & 0xffffULL) << 16;
}
--
2.31.1
next prev parent reply other threads:[~2021-07-13 2:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 2:07 [PULL 0/3] ppc-for-6.1 queue 20210713 David Gibson
2021-07-13 2:07 ` [PULL 1/3] ppc/pegasos2: Allow setprop in VOF David Gibson
2021-07-13 2:07 ` [PULL 2/3] pseries: Update SLOF firmware image David Gibson
2021-07-13 2:07 ` David Gibson [this message]
2021-07-13 20:37 ` [PULL 0/3] ppc-for-6.1 queue 20210713 Peter Maydell
2021-07-17 18:25 ` R: " luigi burdo
2021-07-17 19:55 ` BALATON Zoltan
2021-07-17 22:23 ` R: " luigi burdo
2021-07-20 3:10 ` luigi burdo
2021-07-20 14:02 ` BALATON Zoltan
2021-07-20 14:30 ` R: " luigi burdo
2021-07-20 18:59 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713020736.28960-4-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).