qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH  v1 04/21] configure: remove needless if leg
Date: Wed, 14 Jul 2021 10:36:21 +0100	[thread overview]
Message-ID: <20210714093638.21077-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210714093638.21077-1-alex.bennee@linaro.org>

It was pointed out in review of the previous patch that the if leg
isn't needed as the for loop will not enter on an empty $device_archs.

Fixes: d1d5e9eefd ("configure: allow the selection of alternate config in the build")
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 configure | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/configure b/configure
index 4d0a2bfdd8..013f327f4a 100755
--- a/configure
+++ b/configure
@@ -5083,12 +5083,10 @@ if test "$skip_meson" = no; then
   echo "[properties]" >> $cross
 
   # unroll any custom device configs
-  if test -n "$device_archs"; then
-      for a in $device_archs; do
-          eval "c=\$devices_${a}"
-          echo "${a}-softmmu = '$c'" >> $cross
-      done
-  fi
+  for a in $device_archs; do
+      eval "c=\$devices_${a}"
+      echo "${a}-softmmu = '$c'" >> $cross
+  done
 
   test -z "$cxx" && echo "link_language = 'c'" >> $cross
   echo "[built-in options]" >> $cross
-- 
2.20.1



  parent reply	other threads:[~2021-07-14  9:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14  9:36 [PATCH for 6.1-rc0 v1 00/21] documentation and metadata updates Alex Bennée
2021-07-14  9:36 ` [PATCH v1 01/21] gitignore: Update with some filetypes Alex Bennée
2021-07-14  9:36 ` [PATCH v1 02/21] docs: collect the disparate device emulation docs into one section Alex Bennée
2021-07-14  9:36 ` [PATCH v1 03/21] docs: add a section on the generalities of vhost-user Alex Bennée
2021-07-14  9:36 ` Alex Bennée [this message]
2021-07-14  9:36 ` [PATCH v1 05/21] contrib/gitdm: add some new aliases to fix up commits Alex Bennée
2021-07-14  9:36 ` [PATCH v1 06/21] .mailmap: fix up some broken commit authors Alex Bennée
2021-07-14  9:36 ` [PATCH v1 07/21] contrib/gitdm: add domain-map for MontaVista Alex Bennée
2021-07-14 16:09   ` Corey Minyard
2021-07-14  9:36 ` [PATCH v1 08/21] contrib/gitdm: add a group mapping for robot scanners Alex Bennée
2021-07-14  9:36 ` [PATCH v1 09/21] gitdm.config: sort the corporate GroupMap entries Alex Bennée
2021-07-14  9:36 ` [PATCH v1 10/21] contrib/gitdm: add domain-map/group-map mappings for Samsung Alex Bennée
2021-07-14  9:36 ` [PATCH v1 11/21] contrib/gitdm: add domain-map for Eldorado Alex Bennée
2021-07-14  9:36 ` [PATCH v1 12/21] contrib/gitdm: add domain-map/group-map for Wind River Alex Bennée
2021-07-14  9:36 ` [PATCH v1 13/21] contrib/gitdm: un-ironically add a mapping for LWN Alex Bennée
2021-07-14  9:36 ` [PATCH v1 14/21] contrib/gitdm: add domain-map for Crudebyte Alex Bennée
2021-07-14 10:54   ` Christian Schoenebeck
2021-07-14  9:36 ` [PATCH v1 15/21] contrib/gitdm: add domain-map for ZTE Alex Bennée
2021-07-14  9:36 ` [PATCH v1 16/21] contrib/gitdm: add domain-map for Syrmia Alex Bennée
2021-07-14  9:36 ` [PATCH v1 17/21] contrib/gitdm: add domain-map for NVIDIA Alex Bennée
2021-07-14  9:36 ` [PATCH v1 18/21] contrib/gitdm: add group-map for Netflix Alex Bennée
2021-07-14  9:36 ` [PATCH v1 19/21] contrib/gitdm: add an explicit academic entry for BU Alex Bennée
2021-07-14  9:36 ` [PATCH v1 20/21] contrib/gitdm: add a new interns group-map for GSoC/Outreachy work Alex Bennée
  -- strict thread matches above, loose matches on Subject: below --
2021-07-14  9:36 [PATCH for 6.1-rc0 v1 00/21] documentation and metadata updates Alex Bennée
2021-07-14  9:37 ` [PATCH v1 04/21] configure: remove needless if leg Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210714093638.21077-5-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).