qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH for 6.1] meson.build: relax the libdl test to one for the function dlopen
@ 2021-07-14 10:15 Alex Bennée
  2021-07-14 11:00 ` Paolo Bonzini
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Bennée @ 2021-07-14 10:15 UTC (permalink / raw)
  To: qemu-devel
  Cc: minyihh, robhenry, mahmoudabdalghany, aaron, cota, pbonzini,
	kuhn.chenqun, ma.mandourr, Alex Bennée

For the *BSD family dlopen is already part of libc so it's not a hard
dependency to have a libdl.so library.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 meson.build | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index c6dd70c400..e5de144233 100644
--- a/meson.build
+++ b/meson.build
@@ -455,7 +455,10 @@ endif
 rt = cc.find_library('rt', required: false)
 libdl = not_found
 if 'CONFIG_PLUGIN' in config_host
-  libdl = cc.find_library('dl', required: true)
+  libdl = cc.find_library('dl', required: false)
+  if not cc.has_function('dlopen', dependencies: libdl)
+    error('dlopen not found')
+  endif
 endif
 libiscsi = not_found
 if not get_option('libiscsi').auto() or have_block
-- 
2.32.0.264.g75ae10bc75



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH for 6.1] meson.build: relax the libdl test to one for the function dlopen
  2021-07-14 10:15 [PATCH for 6.1] meson.build: relax the libdl test to one for the function dlopen Alex Bennée
@ 2021-07-14 11:00 ` Paolo Bonzini
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2021-07-14 11:00 UTC (permalink / raw)
  To: Alex Bennée
  Cc: minyihh, qemu-devel, robhenry, mahmoudabdalghany, aaron,
	Emilio G. Cota, kuhn.chenqun, Mahmoud Mandour

> -  libdl = cc.find_library('dl', required: true)
> +  libdl = cc.find_library('dl', required: false)
> +  if not cc.has_function('dlopen', dependencies: libdl)
> +    error('dlopen not found')
> +  endif

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-14 11:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-14 10:15 [PATCH for 6.1] meson.build: relax the libdl test to one for the function dlopen Alex Bennée
2021-07-14 11:00 ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).