From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 503F6C12002 for ; Fri, 16 Jul 2021 08:06:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7813611AC for ; Fri, 16 Jul 2021 08:06:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7813611AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4Irz-0003hR-1X for qemu-devel@archiver.kernel.org; Fri, 16 Jul 2021 04:06:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4IpR-0007Gq-Ns for qemu-devel@nongnu.org; Fri, 16 Jul 2021 04:04:13 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:41558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m4IpQ-0005Kv-7r for qemu-devel@nongnu.org; Fri, 16 Jul 2021 04:04:13 -0400 Received: by mail-wr1-x433.google.com with SMTP id k4so11000427wrc.8 for ; Fri, 16 Jul 2021 01:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qWN2HIRs01eKm6dhCHQnthOBil+q+4JpNVw/kRffS9E=; b=Ik/je3Kbpm5MBKnh9ysuRUlQYcKW81ukCUUPzizt+Z1UCkc+AZbaG8yQbVf0MF8uSZ x9tsZ5X7qSQZgDMZXE9dfShIlb8f+aMpeQ5IXM8pyy2aGIcz46RSbjPs3VeFhIpyDbcn +G4C4xbe3pnD5S7C7RZJ4/fxBZhKV4/at8aCQBLdyAUOz/e6VKnOob5LuC8J8x/IbuWC l/MHY83Po9skgTJcjBZNkpjdoq8jrjzyPuEhD78Fe7s6M1ZHTwjHZrfTLvIsrChAtQtK LR1uJ3NHfRnfy/9xE97zcl8vHvRxKSBJN9h99KIMeJ9Qv10NbMYZigdv/H3hAdyhOW0r w/sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qWN2HIRs01eKm6dhCHQnthOBil+q+4JpNVw/kRffS9E=; b=DuPESpxOVowt5ky+KAEDfCIw7WmTnS0K3zQ98Fqpuuka37pf7oiC5Tg7jmvUNtgDZS n1Xsv+dZt8GWnIHdFzJmaC4PlkSq7ZIckTxk1EbsOOC2Y6PcfHMgqx/p4RD+E3EfDgBA NtPpeqpVYthZS/NozPRvG5LpsblzTsJx7e0KsPHsErXstuNvStF2NcYIOucxJlUy0YDO v8YBguVJyKFZ/aEVYzHtA5sk/7bra2Rb472Q2tSBkSFiajlLW9gCcvCR9rWuJZ8SkmWf W2OFTXeQtbbZqJKePdXNdbY31X6a8LMZybn1pu0LUvDJYe4lGDtF+foIN2JSsOYXcphn ZdLQ== X-Gm-Message-State: AOAM530L0cVsqGDwDdyuzGUz0mRCpl0Pdsn3xSYfbR1BbrISFzKIKFch wFReRnxD+jDLnKjgfu0KAE9GBU6zT6/axg== X-Google-Smtp-Source: ABdhPJyGG7kYeXiI8mfx6rRsOSwiHGbfGimqAVoyqdTbi6ek59K7fHPih3AH2/PyPG/bOja2FZU1EQ== X-Received: by 2002:a5d:6c6d:: with SMTP id r13mr10656450wrz.227.1626422650795; Fri, 16 Jul 2021 01:04:10 -0700 (PDT) Received: from localhost.localdomain ([41.34.125.69]) by smtp.gmail.com with ESMTPSA id p12sm6558046wma.19.2021.07.16.01.04.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jul 2021 01:04:10 -0700 (PDT) From: Mahmoud Mandour To: qemu-devel@nongnu.org Subject: [PATCH 4/9] plugins/hotblocks: Added correct boolean argument parsing Date: Fri, 16 Jul 2021 10:03:40 +0200 Message-Id: <20210716080345.136784-5-ma.mandourr@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210716080345.136784-1-ma.mandourr@gmail.com> References: <20210716080345.136784-1-ma.mandourr@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=ma.mandourr@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mahmoud Mandour , cota@braap.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Mahmoud Mandour --- contrib/plugins/hotblocks.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 4b08340143..062200a7a4 100644 --- a/contrib/plugins/hotblocks.c +++ b/contrib/plugins/hotblocks.c @@ -133,8 +133,18 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_id_t id, const qemu_info_t *info, int argc, char **argv) { - if (argc && strcmp(argv[0], "inline") == 0) { - do_inline = true; + for (int i = 0; i < argc; i++) { + char *opt = argv[i]; + g_autofree char **tokens = g_strsplit(opt, "=", 2); + if (g_strcmp0(tokens[0], "inline") == 0) { + if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &do_inline)) { + fprintf(stderr, "boolean argument parsing failed: %s\n", opt); + return -1; + } + } else { + fprintf(stderr, "option parsing failed: %s\n", opt); + return -1; + } } plugin_init(); -- 2.25.1