From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D58CCC07E95 for ; Fri, 16 Jul 2021 11:23:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C646613F2 for ; Fri, 16 Jul 2021 11:23:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C646613F2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4Lvn-0005pu-Mx for qemu-devel@archiver.kernel.org; Fri, 16 Jul 2021 07:22:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4LuZ-000469-99 for qemu-devel@nongnu.org; Fri, 16 Jul 2021 07:21:43 -0400 Received: from us-smtp-delivery-44.mimecast.com ([205.139.111.44]:58039) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4LuX-0003xZ-Qk for qemu-devel@nongnu.org; Fri, 16 Jul 2021 07:21:42 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-D59qgjrsOyS_UBBOAjHSIQ-1; Fri, 16 Jul 2021 07:21:37 -0400 X-MC-Unique: D59qgjrsOyS_UBBOAjHSIQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B490F802C89; Fri, 16 Jul 2021 11:21:36 +0000 (UTC) Received: from bahia.lan (ovpn-112-127.ams2.redhat.com [10.36.112.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id 455E726FA2; Fri, 16 Jul 2021 11:21:35 +0000 (UTC) Date: Fri, 16 Jul 2021 13:21:34 +0200 From: Greg Kurz To: Daniel Henrique Barboza Subject: Re: [PATCH v5 2/7] spapr.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULL Message-ID: <20210716132134.7725ce9e@bahia.lan> In-Reply-To: <20210712194339.813152-3-danielhb413@gmail.com> References: <20210712194339.813152-1-danielhb413@gmail.com> <20210712194339.813152-3-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=205.139.111.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, eblake@redhat.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 12 Jul 2021 16:43:34 -0300 Daniel Henrique Barboza wrote: > As done in hw/acpi/memory_hotplug.c, avoid sending > qapi_event_send_mem_unplug_error() if dev->id is NULL. >=20 > Suggested-by: Markus Armbruster > Signed-off-by: Daniel Henrique Barboza > --- Reviewed-by: Greg Kurz > hw/ppc/spapr.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 81699d4f8b..1611d7ab05 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -3688,9 +3688,11 @@ void spapr_memory_unplug_rollback(SpaprMachineStat= e *spapr, DeviceState *dev) > * Tell QAPI that something happened and the memory > * hotunplug wasn't successful. > */ > - qapi_error =3D g_strdup_printf("Memory hotunplug rejected by the gue= st " > - "for device %s", dev->id); > - qapi_event_send_mem_unplug_error(dev->id, qapi_error); > + if (dev->id) { > + qapi_error =3D g_strdup_printf("Memory hotunplug rejected by the= guest " > + "for device %s", dev->id); > + qapi_event_send_mem_unplug_error(dev->id, qapi_error); > + } > } > =20 > /* Callback to be called during DRC release. */