From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A61C07E95 for ; Fri, 16 Jul 2021 12:48:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09DAE613EB for ; Fri, 16 Jul 2021 12:48:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09DAE613EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4NGq-0007y8-MH for qemu-devel@archiver.kernel.org; Fri, 16 Jul 2021 08:48:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4NG9-0007Il-MA for qemu-devel@nongnu.org; Fri, 16 Jul 2021 08:48:05 -0400 Received: from us-smtp-delivery-44.mimecast.com ([205.139.111.44]:48063) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4NG7-0001pd-Ht for qemu-devel@nongnu.org; Fri, 16 Jul 2021 08:48:05 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-SsBEuo6fNDelgazjL7qS-g-1; Fri, 16 Jul 2021 08:48:01 -0400 X-MC-Unique: SsBEuo6fNDelgazjL7qS-g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6ADC1804140; Fri, 16 Jul 2021 12:48:00 +0000 (UTC) Received: from bahia.lan (ovpn-112-127.ams2.redhat.com [10.36.112.127]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF6915D6AB; Fri, 16 Jul 2021 12:47:58 +0000 (UTC) Date: Fri, 16 Jul 2021 14:47:57 +0200 From: Greg Kurz To: Daniel Henrique Barboza Subject: Re: [PATCH v5 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc Message-ID: <20210716144757.6c53cec3@bahia.lan> In-Reply-To: <20210712194339.813152-5-danielhb413@gmail.com> References: <20210712194339.813152-1-danielhb413@gmail.com> <20210712194339.813152-5-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=205.139.111.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, eblake@redhat.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 12 Jul 2021 16:43:36 -0300 Daniel Henrique Barboza wrote: > Clarify that @device is optional and that 'path' is the device > path from QOM. >=20 > This change follows Markus' suggestion verbatim, provided in full > context here: >=20 > https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01891.html >=20 > Suggested-by: Markus Armbruster > Signed-off-by: Daniel Henrique Barboza > --- Reviewed-by: Greg Kurz > qapi/qdev.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/qapi/qdev.json b/qapi/qdev.json > index b83178220b..d1d3681a50 100644 > --- a/qapi/qdev.json > +++ b/qapi/qdev.json > @@ -108,9 +108,9 @@ > # At this point, it's safe to reuse the specified device ID. Device remo= val can > # be initiated by the guest or by HMP/QMP commands. > # > -# @device: device name > +# @device: the device's ID if it has one > # > -# @path: device path > +# @path: the device's path within the object model > # > # Since: 1.5 > #