From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>
Subject: [PATCH for-6.2 09/10] linux-user: Drop unneeded includes from qemu.h
Date: Sun, 18 Jul 2021 00:21:02 +0100 [thread overview]
Message-ID: <20210717232103.18047-10-peter.maydell@linaro.org> (raw)
In-Reply-To: <20210717232103.18047-1-peter.maydell@linaro.org>
Trim down the #includes in qemu.h where we can, either by
dropping unneeded headers or by moving them to user-internals.h.
This includes deleting a couple of #includes that appear at
weird points midway through the header file.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
linux-user/qemu.h | 4 ----
linux-user/user-internals.h | 2 ++
thunk.c | 1 +
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index fda90fc28d6..5c713fa8ab2 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -2,7 +2,6 @@
#define QEMU_H
#include "cpu.h"
-#include "exec/exec-all.h"
#include "exec/cpu_ldst.h"
#undef DEBUG_REMAP
@@ -163,8 +162,6 @@ typedef struct TaskState {
struct target_sigaltstack sigaltstack_used;
} __attribute__((aligned(16))) TaskState;
-#include "qemu/log.h"
-
abi_long do_brk(abi_ulong new_brk);
/* user access */
@@ -349,5 +346,4 @@ void *lock_user_string(abi_ulong guest_addr);
#define unlock_user_struct(host_ptr, guest_addr, copy) \
unlock_user(host_ptr, guest_addr, (copy) ? sizeof(*host_ptr) : 0)
-#include <pthread.h>
#endif /* QEMU_H */
diff --git a/linux-user/user-internals.h b/linux-user/user-internals.h
index 1729a8b62e1..661612a088b 100644
--- a/linux-user/user-internals.h
+++ b/linux-user/user-internals.h
@@ -20,6 +20,8 @@
#include "hostdep.h"
#include "exec/user/thunk.h"
+#include "exec/exec-all.h"
+#include "qemu/log.h"
extern char *exec_path;
void init_task_state(TaskState *ts);
diff --git a/thunk.c b/thunk.c
index fc5be1a502e..dac4bf11c65 100644
--- a/thunk.c
+++ b/thunk.c
@@ -17,6 +17,7 @@
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "qemu.h"
#include "exec/user/thunk.h"
--
2.20.1
next prev parent reply other threads:[~2021-07-17 23:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 23:20 [PATCH for-6.2 00/10] linux-user: split internals out of qemu.h Peter Maydell
2021-07-17 23:20 ` [PATCH for-6.2 01/10] linux-user: Fix coding style nits in qemu.h Peter Maydell
2021-07-18 7:41 ` Philippe Mathieu-Daudé
2021-07-17 23:20 ` [PATCH for-6.2 02/10] linux-user: Split strace prototypes into strace.h Peter Maydell
2021-07-18 7:42 ` Philippe Mathieu-Daudé
2021-07-17 23:20 ` [PATCH for-6.2 03/10] linux-user: Split signal-related prototypes into sighandling.h Peter Maydell
2021-07-18 7:46 ` Philippe Mathieu-Daudé
2021-07-18 9:37 ` Peter Maydell
2021-07-17 23:20 ` [PATCH for-6.2 04/10] linux-user: Split loader-related prototypes into loader.h Peter Maydell
2021-07-17 23:20 ` [PATCH for-6.2 05/10] linux-user: Split mmap prototypes into user-mmap.h Peter Maydell
2021-07-17 23:40 ` Peter Maydell
2021-07-17 23:20 ` [PATCH for-6.2 06/10] linux-user: Split safe-syscall macro into its own header Peter Maydell
2021-07-18 7:49 ` Philippe Mathieu-Daudé
2021-07-17 23:21 ` [PATCH for-6.2 07/10] linux-user: Split linux-user internals out of qemu.h Peter Maydell
2021-07-17 23:21 ` [PATCH for-6.2 08/10] linux-user: Don't include gdbstub.h in qemu.h Peter Maydell
2021-07-18 7:50 ` Philippe Mathieu-Daudé
2021-07-17 23:21 ` Peter Maydell [this message]
2021-07-18 7:51 ` [PATCH for-6.2 09/10] linux-user: Drop unneeded includes from qemu.h Philippe Mathieu-Daudé
2021-07-17 23:21 ` [PATCH for-6.2 10/10] linux-user: Move DEBUG_REMAP undef to uaccess.c Peter Maydell
2021-07-17 23:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210717232103.18047-10-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).