From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E552C07E9B for ; Mon, 19 Jul 2021 10:11:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F70A608FE for ; Mon, 19 Jul 2021 10:11:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F70A608FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5QFS-0003IT-SR for qemu-devel@archiver.kernel.org; Mon, 19 Jul 2021 06:11:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5QE3-0001oh-Gy for qemu-devel@nongnu.org; Mon, 19 Jul 2021 06:10:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46302) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5QDx-0003jT-90 for qemu-devel@nongnu.org; Mon, 19 Jul 2021 06:10:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626689408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ix8W3EUtgdR5oIgOXT1LXC9TnMTp9gpGM9x+B23Aqb4=; b=TSh+5RGUHOeffdI03ADYp4VqNVmtcvbzEZGrqYd15CPQ2pyT5MQhRJldQg3c89iN/VaBdo a3HR3yzJ+fbzINS4Aw9xXjQXz4grA7vOfGRWp9Qk2vSlOYucf0vEoo+3+Ly56ROohidh+z z9y9zSWE/tXaePrc+aG5AjNMuwUIXMc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-VejuyBs9NpWU67lJnYXCKA-1; Mon, 19 Jul 2021 06:10:05 -0400 X-MC-Unique: VejuyBs9NpWU67lJnYXCKA-1 Received: by mail-wm1-f70.google.com with SMTP id v25-20020a1cf7190000b0290197a4be97b7so5238522wmh.9 for ; Mon, 19 Jul 2021 03:10:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ix8W3EUtgdR5oIgOXT1LXC9TnMTp9gpGM9x+B23Aqb4=; b=iWib7fZyV6BuAJhhVIN8mjvQSY0t2VB+FvH70jgtVp4wPJ3muZxdCt/lbKtgOOfgKI tuAEdbpStNFHps1Ocg2xgwWTQVXyusnMLeuS3T/IeutcW239r6Twcm6GxsGzRsntRovL tJ9101eoXk6aU5fE2hGTVWGhX6HhNTn2VL0dhwX2LNjQXIYVAt11iC1bI/7cVhUpIEr1 rKE2492kK73S5+ZH8GWLO8EEivku1+yrDt8yPqeok7yrtR+7rDsEZfTbMDVMJ7eyLiG7 CM/xTXD1OV3TBNKS90StA/8HQt+ul/5Is04H7ikoSh0HNrq1gAzvkfZsvw/jl8V1vAXt t6BA== X-Gm-Message-State: AOAM531+VHzt2bo4W4Zaf/N4difLk0U6P+3esYzT+pqcfjndUDa7Wd+S 83Jet0gIUwckCrOUawAjEM56ag0BuuQixWuAOvSgmQJ5A9zzLoqjrzE93tUucHeCdvihBoB8HG6 evMjMH4RUmR1etvU= X-Received: by 2002:a05:600c:4846:: with SMTP id j6mr17538014wmo.4.1626689404014; Mon, 19 Jul 2021 03:10:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2BrRqa3auyoBHZSvwVOyOFgVd3ePCwIksPRQOO4KWmEEjoVjue/vq6DXDZTNSVNPQ7kpXHw== X-Received: by 2002:a05:600c:4846:: with SMTP id j6mr17537972wmo.4.1626689403663; Mon, 19 Jul 2021 03:10:03 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id q72sm12414570wme.14.2021.07.19.03.10.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 03:10:03 -0700 (PDT) Date: Mon, 19 Jul 2021 12:10:00 +0200 From: Stefano Garzarella To: Stefan Hajnoczi Subject: Re: [PATCH 2/3] iothread: add aio-max-batch parameter Message-ID: <20210719101000.27xtuwc6st3sy54u@steredhat> References: <20210707150019.201442-1-sgarzare@redhat.com> <20210707150019.201442-3-sgarzare@redhat.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=sgarzare@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.466, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= , Eduardo Habkost , qemu-block@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Max Reitz , Stefan Weil , Paolo Bonzini , Eric Blake , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 13, 2021 at 03:51:15PM +0100, Stefan Hajnoczi wrote: >On Wed, Jul 07, 2021 at 05:00:18PM +0200, Stefano Garzarella wrote: >> diff --git a/qapi/misc.json b/qapi/misc.json >> index 156f98203e..f64bb69f74 100644 >> --- a/qapi/misc.json >> +++ b/qapi/misc.json >> @@ -86,6 +86,9 @@ >> # @poll-shrink: how many ns will be removed from polling time, 0 means that >> # it's not configured (since 2.9) >> # >> +# @aio-max-batch: maximum number of requests in a bacth for the AIO engine, > >s/bacth/batch/ > >> +# 0 means that the engine will use its default (since 6.1) >> +# >> # Since: 2.0 >> ## >> { 'struct': 'IOThreadInfo', >> @@ -93,7 +96,8 @@ >> 'thread-id': 'int', >> 'poll-max-ns': 'int', >> 'poll-grow': 'int', >> - 'poll-shrink': 'int' } } >> + 'poll-shrink': 'int', >> + 'aio-max-batch': 'int' } } >> >> ## >> # @query-iothreads: >> diff --git a/qapi/qom.json b/qapi/qom.json >> index 652be317b8..23fd586614 100644 >> --- a/qapi/qom.json >> +++ b/qapi/qom.json >> @@ -516,12 +516,17 @@ >> # algorithm detects it is spending too long polling without >> # encountering events. 0 selects a default behaviour (default: 0) >> # >> +# @aio-max-batch: maximum number of requests in a bacth for the AIO engine, > >s/bacth/batch/ Fixed in v2 also in include/block/aio.h :-) Thanks, Stefano