qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: marcandre.lureau@redhat.com, philmd@redhat.com,
	qemu-devel@nongnu.org, Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH v5 06/10] tests: tpm: Create TPM 1.2 response in TPM emulator
Date: Mon, 19 Jul 2021 17:13:27 +0200	[thread overview]
Message-ID: <20210719171327.7705022e@redhat.com> (raw)
In-Reply-To: <20210713201545.903754-7-stefanb@linux.vnet.ibm.com>

On Tue, 13 Jul 2021 16:15:41 -0400
Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:

> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

Acked-by: Igor Mammedov <imammedo@redhat.com>

> 
> ---
> v3:
>   - Added TPM_VERSION_1_2 enum for when CONFIG_TPM is not defined
> ---
>  tests/qtest/tpm-emu.c | 5 +++++
>  tests/qtest/tpm-emu.h | 4 ++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/tests/qtest/tpm-emu.c b/tests/qtest/tpm-emu.c
> index 8baf49eafd..32c704194b 100644
> --- a/tests/qtest/tpm-emu.c
> +++ b/tests/qtest/tpm-emu.c
> @@ -62,6 +62,11 @@ static void *tpm_emu_tpm_thread(void *data)
>              s->tpm_msg->len = cpu_to_be32(sizeof(struct tpm_hdr));
>              s->tpm_msg->code = cpu_to_be32(TPM_RC_FAILURE);
>              break;
> +        case TPM_VERSION_1_2:
> +            s->tpm_msg->tag = cpu_to_be16(TPM_TAG_RSP_COMMAND);
> +            s->tpm_msg->len = cpu_to_be32(sizeof(struct tpm_hdr));
> +            s->tpm_msg->code = cpu_to_be32(TPM_FAIL);
> +            break;
>          default:
>              g_debug("unsupport TPM version %u", s->tpm_version);
>              g_assert_not_reached();
> diff --git a/tests/qtest/tpm-emu.h b/tests/qtest/tpm-emu.h
> index 610519883a..fcb5d7a1d6 100644
> --- a/tests/qtest/tpm-emu.h
> +++ b/tests/qtest/tpm-emu.h
> @@ -16,6 +16,9 @@
>  #define TPM_RC_FAILURE 0x101
>  #define TPM2_ST_NO_SESSIONS 0x8001
>  
> +#define TPM_FAIL 9
> +#define TPM_TAG_RSP_COMMAND 0xc4
> +
>  #include "qemu/sockets.h"
>  #include "io/channel.h"
>  #include "sysemu/tpm.h"
> @@ -29,6 +32,7 @@ struct tpm_hdr {
>  
>  #ifndef CONFIG_TPM
>  enum TPMVersion {
> +    TPM_VERSION_1_2 = 1,
>      TPM_VERSION_2_0 = 2,
>  };
>  #endif



  reply	other threads:[~2021-07-19 15:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 20:15 [PATCH v5 00/10] tests: Add test cases for TPM 1.2 ACPI tables Stefan Berger
2021-07-13 20:15 ` [PATCH v5 01/10] tests: Rename TestState to TPMTestState Stefan Berger
2021-07-13 20:15 ` [PATCH v5 02/10] tests: Add tpm_version field to TPMTestState and fill it Stefan Berger
2021-07-19 15:12   ` Igor Mammedov
2021-07-13 20:15 ` [PATCH v5 03/10] tests: acpi: Prepare for renaming of TPM2 related ACPI files Stefan Berger
2021-07-13 20:15 ` [PATCH v5 04/10] tests: Add suffix 'tpm2' or 'tpm12' to ACPI table files Stefan Berger
2021-07-13 20:15 ` [PATCH v5 05/10] tests: acpi: tpm2: Add the renamed ACPI files and drop old ones Stefan Berger
2021-07-13 20:15 ` [PATCH v5 06/10] tests: tpm: Create TPM 1.2 response in TPM emulator Stefan Berger
2021-07-19 15:13   ` Igor Mammedov [this message]
2021-07-13 20:15 ` [PATCH v5 07/10] tests: acpi: prepare for new TPM 1.2 related tables Stefan Berger
2021-07-13 20:15 ` [PATCH v5 08/10] tests: Use QMP to check whether a TPM device model is available Stefan Berger
2021-07-19 20:36   ` Stefan Berger
2021-07-13 20:15 ` [PATCH v5 09/10] tests: acpi: Add test cases for TPM 1.2 with TCPA table Stefan Berger
2021-07-13 20:15 ` [PATCH v5 10/10] tests: acpi: tpm1.2: Add expected TPM 1.2 ACPI blobs Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210719171327.7705022e@redhat.com \
    --to=imammedo@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.ibm.com \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).