From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk,
alex.bennee@linaro.org, f4bug@amsat.org
Subject: [PATCH for-6.1 v5 00/15] tcg: breakpoint reorg
Date: Mon, 19 Jul 2021 15:17:45 -1000 [thread overview]
Message-ID: <20210720011800.483966-1-richard.henderson@linaro.org> (raw)
This is fixing #404 ("windows xp boot takes much longer...")
and several other similar reports.
Changes for v5:
* Include missing hunk in tb_gen_code, as noted in reply to v4.
* Remove helper_check_breakpoints from target/arm/.
* Reorg cflags_for_breakpoints into check_for_breakpoints;
reorg cpu_exec to use a break instead of a longjmp.
* Move singlestep_enabled check from cflags_for_breakpoints
to curr_cflags, which makes cpu_exec_step_atomic cleaner.
Changes for v4:
* Issue breakpoints directly from cflags_for_breakpoints.
Do not generate code for a TB beginning with a BP at all.
* Drop the problematic TranslatorOps.breakpoint_check hook entirely.
Changes for v3:
* Map CF_COUNT_MASK == 0 -> TCG_MAX_INSNS.
* Split out *_breakpoint_check fixes for avr, mips, riscv.
Changes for v2:
* All prerequisites and 7 of the patches from v1 with are merged.
Patches lacking review are all new:
03-target-alpha-Drop-goto_tb-path-in-gen_call_pal.patch
08-hw-core-Introduce-TCGCPUOps.debug_check_breakpoin.patch
09-target-arm-Implement-debug_check_breakpoint.patch
10-target-i386-Implement-debug_check_breakpoint.patch
11-accel-tcg-Merge-tb_find-into-its-only-caller.patch
12-accel-tcg-Move-breakpoint-recognition-outside-tra.patch
13-accel-tcg-Remove-TranslatorOps.breakpoint_check.patch
15-accel-tcg-Record-singlestep_enabled-in-tb-cflags.patch
r~
Richard Henderson (15):
accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS
accel/tcg: Move curr_cflags into cpu-exec.c
target/alpha: Drop goto_tb path in gen_call_pal
accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR
accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain
accel/tcg: Handle -singlestep in curr_cflags
accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic
hw/core: Introduce TCGCPUOps.debug_check_breakpoint
target/arm: Implement debug_check_breakpoint
target/i386: Implement debug_check_breakpoint
accel/tcg: Merge tb_find into its only caller
accel/tcg: Move breakpoint recognition outside translation
accel/tcg: Remove TranslatorOps.breakpoint_check
accel/tcg: Hoist tb_cflags to a local in translator_loop
accel/tcg: Record singlestep_enabled in tb->cflags
include/exec/exec-all.h | 24 +++--
include/exec/translator.h | 11 --
include/hw/core/tcg-cpu-ops.h | 6 ++
target/arm/helper.h | 2 -
target/arm/internals.h | 3 +
accel/tcg/cpu-exec.c | 192 +++++++++++++++++++++++++---------
accel/tcg/translate-all.c | 7 +-
accel/tcg/translator.c | 39 ++-----
cpu.c | 24 -----
target/alpha/translate.c | 31 +-----
target/arm/cpu.c | 1 +
target/arm/cpu_tcg.c | 1 +
target/arm/debug_helper.c | 12 +--
target/arm/translate-a64.c | 25 -----
target/arm/translate.c | 29 -----
target/avr/translate.c | 10 --
target/cris/translate.c | 20 ----
target/hexagon/translate.c | 17 ---
target/hppa/translate.c | 11 --
target/i386/tcg/tcg-cpu.c | 12 +++
target/i386/tcg/translate.c | 28 -----
target/m68k/translate.c | 18 ----
target/microblaze/translate.c | 18 ----
target/mips/tcg/translate.c | 19 ----
target/nios2/translate.c | 27 -----
target/openrisc/translate.c | 17 ---
target/ppc/translate.c | 18 ----
target/riscv/translate.c | 17 ---
target/rx/translate.c | 14 ---
target/s390x/tcg/translate.c | 24 -----
target/sh4/translate.c | 18 ----
target/sparc/translate.c | 17 ---
target/tricore/translate.c | 16 ---
target/xtensa/translate.c | 17 ---
tcg/tcg-op.c | 28 +++--
35 files changed, 206 insertions(+), 567 deletions(-)
--
2.25.1
next reply other threads:[~2021-07-20 1:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 1:17 Richard Henderson [this message]
2021-07-20 1:17 ` [PATCH for-6.1 v5 01/15] accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 02/15] accel/tcg: Move curr_cflags into cpu-exec.c Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 03/15] target/alpha: Drop goto_tb path in gen_call_pal Richard Henderson
2021-07-20 11:55 ` Philippe Mathieu-Daudé
2021-07-20 1:17 ` [PATCH for-6.1 v5 04/15] accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 05/15] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 06/15] accel/tcg: Handle -singlestep in curr_cflags Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 07/15] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 08/15] hw/core: Introduce TCGCPUOps.debug_check_breakpoint Richard Henderson
2021-07-20 11:52 ` Philippe Mathieu-Daudé
2021-07-20 1:17 ` [PATCH for-6.1 v5 09/15] target/arm: Implement debug_check_breakpoint Richard Henderson
2021-07-20 11:52 ` Philippe Mathieu-Daudé
2021-07-20 1:17 ` [PATCH for-6.1 v5 10/15] target/i386: " Richard Henderson
2021-07-20 13:06 ` Alex Bennée
2021-07-20 1:17 ` [PATCH for-6.1 v5 11/15] accel/tcg: Merge tb_find into its only caller Richard Henderson
2021-07-20 13:15 ` Alex Bennée
2021-07-20 1:17 ` [PATCH for-6.1 v5 12/15] accel/tcg: Move breakpoint recognition outside translation Richard Henderson
2021-07-20 13:16 ` Alex Bennée
2021-07-20 16:12 ` Alex Bennée
2021-07-20 1:17 ` [PATCH for-6.1 v5 13/15] accel/tcg: Remove TranslatorOps.breakpoint_check Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 14/15] accel/tcg: Hoist tb_cflags to a local in translator_loop Richard Henderson
2021-07-20 11:54 ` Philippe Mathieu-Daudé
2021-07-20 1:18 ` [PATCH for-6.1 v5 15/15] accel/tcg: Record singlestep_enabled in tb->cflags Richard Henderson
2021-07-20 2:04 ` [PATCH for-6.1 v5 00/15] tcg: breakpoint reorg Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720011800.483966-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).