From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk,
alex.bennee@linaro.org, f4bug@amsat.org
Subject: [PATCH for-6.1 v5 03/15] target/alpha: Drop goto_tb path in gen_call_pal
Date: Mon, 19 Jul 2021 15:17:48 -1000 [thread overview]
Message-ID: <20210720011800.483966-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210720011800.483966-1-richard.henderson@linaro.org>
We are certain of a page crossing here, entering the
PALcode image, so the call to use_goto_tb that should
have been here will never succeed.
We are shortly going to add an assert to tcg_gen_goto_tb
that would trigger for this case.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/alpha/translate.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index 103c6326a2..949ba6ffde 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -1207,19 +1207,8 @@ static DisasJumpType gen_call_pal(DisasContext *ctx, int palcode)
? 0x2000 + (palcode - 0x80) * 64
: 0x1000 + palcode * 64);
- /* Since the destination is running in PALmode, we don't really
- need the page permissions check. We'll see the existence of
- the page when we create the TB, and we'll flush all TBs if
- we change the PAL base register. */
- if (!ctx->base.singlestep_enabled) {
- tcg_gen_goto_tb(0);
- tcg_gen_movi_i64(cpu_pc, entry);
- tcg_gen_exit_tb(ctx->base.tb, 0);
- return DISAS_NORETURN;
- } else {
- tcg_gen_movi_i64(cpu_pc, entry);
- return DISAS_PC_UPDATED;
- }
+ tcg_gen_movi_i64(cpu_pc, entry);
+ return DISAS_PC_UPDATED;
}
#endif
}
--
2.25.1
next prev parent reply other threads:[~2021-07-20 1:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 1:17 [PATCH for-6.1 v5 00/15] tcg: breakpoint reorg Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 01/15] accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 02/15] accel/tcg: Move curr_cflags into cpu-exec.c Richard Henderson
2021-07-20 1:17 ` Richard Henderson [this message]
2021-07-20 11:55 ` [PATCH for-6.1 v5 03/15] target/alpha: Drop goto_tb path in gen_call_pal Philippe Mathieu-Daudé
2021-07-20 1:17 ` [PATCH for-6.1 v5 04/15] accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 05/15] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 06/15] accel/tcg: Handle -singlestep in curr_cflags Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 07/15] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 08/15] hw/core: Introduce TCGCPUOps.debug_check_breakpoint Richard Henderson
2021-07-20 11:52 ` Philippe Mathieu-Daudé
2021-07-20 1:17 ` [PATCH for-6.1 v5 09/15] target/arm: Implement debug_check_breakpoint Richard Henderson
2021-07-20 11:52 ` Philippe Mathieu-Daudé
2021-07-20 1:17 ` [PATCH for-6.1 v5 10/15] target/i386: " Richard Henderson
2021-07-20 13:06 ` Alex Bennée
2021-07-20 1:17 ` [PATCH for-6.1 v5 11/15] accel/tcg: Merge tb_find into its only caller Richard Henderson
2021-07-20 13:15 ` Alex Bennée
2021-07-20 1:17 ` [PATCH for-6.1 v5 12/15] accel/tcg: Move breakpoint recognition outside translation Richard Henderson
2021-07-20 13:16 ` Alex Bennée
2021-07-20 16:12 ` Alex Bennée
2021-07-20 1:17 ` [PATCH for-6.1 v5 13/15] accel/tcg: Remove TranslatorOps.breakpoint_check Richard Henderson
2021-07-20 1:17 ` [PATCH for-6.1 v5 14/15] accel/tcg: Hoist tb_cflags to a local in translator_loop Richard Henderson
2021-07-20 11:54 ` Philippe Mathieu-Daudé
2021-07-20 1:18 ` [PATCH for-6.1 v5 15/15] accel/tcg: Record singlestep_enabled in tb->cflags Richard Henderson
2021-07-20 2:04 ` [PATCH for-6.1 v5 00/15] tcg: breakpoint reorg Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720011800.483966-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).