From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk,
alex.bennee@linaro.org, f4bug@amsat.org
Subject: [PATCH for-6.1 v6 10/17] target/i386: Implement debug_check_breakpoint
Date: Tue, 20 Jul 2021 09:54:32 -1000 [thread overview]
Message-ID: <20210720195439.626594-11-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210720195439.626594-1-richard.henderson@linaro.org>
Return false for RF set, as we do in i386_tr_breakpoint_check.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/i386/tcg/tcg-cpu.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/target/i386/tcg/tcg-cpu.c b/target/i386/tcg/tcg-cpu.c
index e96ec9bbcc..238e3a9395 100644
--- a/target/i386/tcg/tcg-cpu.c
+++ b/target/i386/tcg/tcg-cpu.c
@@ -54,6 +54,17 @@ static void x86_cpu_synchronize_from_tb(CPUState *cs,
cpu->env.eip = tb->pc - tb->cs_base;
}
+#ifndef CONFIG_USER_ONLY
+static bool x86_debug_check_breakpoint(CPUState *cs)
+{
+ X86CPU *cpu = X86_CPU(cs);
+ CPUX86State *env = &cpu->env;
+
+ /* RF disables all architectural breakpoints. */
+ return !(env->eflags & RF_MASK);
+}
+#endif
+
#include "hw/core/tcg-cpu-ops.h"
static const struct TCGCPUOps x86_tcg_ops = {
@@ -66,6 +77,7 @@ static const struct TCGCPUOps x86_tcg_ops = {
.tlb_fill = x86_cpu_tlb_fill,
#ifndef CONFIG_USER_ONLY
.debug_excp_handler = breakpoint_handler,
+ .debug_check_breakpoint = x86_debug_check_breakpoint,
#endif /* !CONFIG_USER_ONLY */
};
--
2.25.1
next prev parent reply other threads:[~2021-07-20 20:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 19:54 [PATCH for-6.1 v6 00/17] tcg: breakpoint reorg Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 01/17] accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 02/17] accel/tcg: Move curr_cflags into cpu-exec.c Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 03/17] target/alpha: Drop goto_tb path in gen_call_pal Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 04/17] accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 05/17] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 06/17] accel/tcg: Handle -singlestep in curr_cflags Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 07/17] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 08/17] hw/core: Introduce TCGCPUOps.debug_check_breakpoint Richard Henderson
2021-07-21 10:33 ` Alex Bennée
2021-07-20 19:54 ` [PATCH for-6.1 v6 09/17] target/arm: Implement debug_check_breakpoint Richard Henderson
2021-07-21 10:35 ` Alex Bennée
2021-07-20 19:54 ` Richard Henderson [this message]
2021-07-20 19:54 ` [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint Richard Henderson
2021-07-20 20:56 ` Peter Maydell
2021-07-20 21:08 ` Richard Henderson
2021-07-20 21:53 ` Philippe Mathieu-Daudé
2021-07-20 22:23 ` Philippe Mathieu-Daudé
2021-07-21 9:56 ` Alex Bennée
2021-07-21 6:12 ` Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 12/17] target/avr: Implement gdb_adjust_breakpoint Richard Henderson
2021-07-20 22:09 ` Philippe Mathieu-Daudé
2021-07-20 19:54 ` [PATCH for-6.1 v6 13/17] accel/tcg: Merge tb_find into its only caller Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 14/17] accel/tcg: Move breakpoint recognition outside translation Richard Henderson
2023-11-28 11:08 ` Philippe Mathieu-Daudé
2023-11-28 18:05 ` Richard Henderson
2023-11-29 15:41 ` Max Filippov
2021-07-20 19:54 ` [PATCH for-6.1 v6 15/17] accel/tcg: Remove TranslatorOps.breakpoint_check Richard Henderson
2021-07-20 20:45 ` Peter Maydell
2021-07-20 22:11 ` Philippe Mathieu-Daudé
2021-07-20 19:54 ` [PATCH for-6.1 v6 16/17] accel/tcg: Hoist tb_cflags to a local in translator_loop Richard Henderson
2021-07-20 19:54 ` [PATCH for-6.1 v6 17/17] accel/tcg: Record singlestep_enabled in tb->cflags Richard Henderson
2021-07-20 20:47 ` Peter Maydell
2021-07-21 10:38 ` Alex Bennée
2021-07-21 16:41 ` Richard Henderson
2021-07-21 16:48 ` Alex Bennée
2021-07-20 21:47 ` [PATCH for-6.1 v6 00/17] tcg: breakpoint reorg Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720195439.626594-11-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).