From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, armbru@redhat.com, eblake@redhat.com,
crosa@redhat.com, ehabkost@redhat.com, berrange@redhat.com,
pbonzini@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com,
mreitz@redhat.com, kwolf@redhat.com
Subject: [PATCH v6 15/33] block/copy-before-write: cbw_init(): rename variables
Date: Wed, 21 Jul 2021 13:05:37 +0300 [thread overview]
Message-ID: <20210721100555.45594-16-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210721100555.45594-1-vsementsov@virtuozzo.com>
One more step closer to real .bdrv_open() handler: use more usual names
for bs being initialized and its state.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
block/copy-before-write.c | 29 ++++++++++++++---------------
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
index a4fee645fd..d7f1833efa 100644
--- a/block/copy-before-write.c
+++ b/block/copy-before-write.c
@@ -144,38 +144,37 @@ static void cbw_child_perm(BlockDriverState *bs, BdrvChild *c,
}
}
-static int cbw_init(BlockDriverState *top, BlockDriverState *source,
+static int cbw_init(BlockDriverState *bs, BlockDriverState *source,
BlockDriverState *target, bool compress, Error **errp)
{
- BDRVCopyBeforeWriteState *state = top->opaque;
+ BDRVCopyBeforeWriteState *s = bs->opaque;
- top->total_sectors = source->total_sectors;
- top->supported_write_flags = BDRV_REQ_WRITE_UNCHANGED |
+ bs->total_sectors = source->total_sectors;
+ bs->supported_write_flags = BDRV_REQ_WRITE_UNCHANGED |
(BDRV_REQ_FUA & source->supported_write_flags);
- top->supported_zero_flags = BDRV_REQ_WRITE_UNCHANGED |
+ bs->supported_zero_flags = BDRV_REQ_WRITE_UNCHANGED |
((BDRV_REQ_FUA | BDRV_REQ_MAY_UNMAP | BDRV_REQ_NO_FALLBACK) &
source->supported_zero_flags);
bdrv_ref(target);
- state->target = bdrv_attach_child(top, target, "target", &child_of_bds,
- BDRV_CHILD_DATA, errp);
- if (!state->target) {
+ s->target = bdrv_attach_child(bs, target, "target", &child_of_bds,
+ BDRV_CHILD_DATA, errp);
+ if (!s->target) {
error_prepend(errp, "Cannot attach target child: ");
return -EINVAL;
}
bdrv_ref(source);
- top->file = bdrv_attach_child(top, source, "file", &child_of_bds,
- BDRV_CHILD_FILTERED | BDRV_CHILD_PRIMARY,
- errp);
- if (!top->file) {
+ bs->file = bdrv_attach_child(bs, source, "file", &child_of_bds,
+ BDRV_CHILD_FILTERED | BDRV_CHILD_PRIMARY,
+ errp);
+ if (!bs->file) {
error_prepend(errp, "Cannot attach file child: ");
return -EINVAL;
}
- state->bcs = block_copy_state_new(top->file, state->target, false, compress,
- errp);
- if (!state->bcs) {
+ s->bcs = block_copy_state_new(bs->file, s->target, false, compress, errp);
+ if (!s->bcs) {
error_prepend(errp, "Cannot create block-copy-state: ");
return -EINVAL;
}
--
2.29.2
next prev parent reply other threads:[~2021-07-21 10:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 10:05 [PATCH v6 00/33] block: publish backup-top filter Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 01/33] block: introduce bdrv_replace_child_bs() Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 02/33] block: introduce blk_replace_bs Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 03/33] qdev-properties: PropertyInfo: add realized_set_allowed field Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 04/33] qdev: allow setting drive property for realized device Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 05/33] block: rename backup-top to copy-before-write Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 06/33] block-copy: always set BDRV_REQ_SERIALISING flag Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 07/33] block/block-copy: introduce block_copy_set_copy_opts() Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 08/33] block/backup: set copy_range and compress after filter insertion Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 09/33] block/backup: move cluster size calculation to block-copy Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 10/33] block/copy-before-write: relax permission requirements when no parents Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 11/33] block/copy-before-write: drop extra bdrv_unref on failure path Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 12/33] block/copy-before-write: use file child instead of backing Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 13/33] block/copy-before-write: bdrv_cbw_append(): replace child at last Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 14/33] block/copy-before-write: introduce cbw_init() Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` Vladimir Sementsov-Ogievskiy [this message]
2021-07-21 10:05 ` [PATCH v6 16/33] block/copy-before-write: cbw_init(): use file child after attaching Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 17/33] block/copy-before-write: bdrv_cbw_append(): drop unused compress arg Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 18/33] block/copy-before-write: cbw_init(): use options Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 19/33] block/copy-before-write: initialize block-copy bitmap Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 20/33] block/block-copy: make setting progress optional Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 21/33] block/copy-before-write: make public block driver Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 22/33] qapi: publish copy-before-write filter Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 23/33] python/qemu/machine.py: refactor _qemu_args() Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 24/33] python/qemu/machine: QEMUMachine: improve qmp() method Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 25/33] iotests.py: VM: add own __enter__ method Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 26/33] iotests/222: fix pylint and mypy complains Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 27/33] iotests/222: constantly use single quotes for strings Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 28/33] iotests: move 222 to tests/image-fleecing Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 29/33] iotests.py: hmp_qemu_io: support qdev Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 30/33] iotests/image-fleecing: proper source device Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 31/33] iotests/image-fleecing: rename tgt_node Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 32/33] iotests/image-fleecing: prepare for adding new test-case Vladimir Sementsov-Ogievskiy
2021-07-21 10:05 ` [PATCH v6 33/33] iotests/image-fleecing: add test-case for copy-before-write filter Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721100555.45594-16-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).